Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Allow custom session key generators #10

Closed
ghost opened this issue Mar 18, 2018 · 1 comment
Closed

Allow custom session key generators #10

ghost opened this issue Mar 18, 2018 · 1 comment
Assignees
Labels
feature request A server feature request, suggestion or proposal
Milestone

Comments

@ghost
Copy link

ghost commented Mar 18, 2018

Currently, there's no way to implement your own session key generator which is rather restrictive. It'd be nice to have the possibility to provide your own generator or use the built-in generator by default.

@romshark romshark added this to the v1.0.0 rc1 milestone Mar 18, 2018
@romshark romshark self-assigned this Mar 21, 2018
@romshark
Copy link
Owner

romshark commented Mar 21, 2018

As of commit #a1ec834 support for custom session key generators is fully implemented and tested.

A custom key generator can now be passed to the new server hook OnSessionKeyGeneration.

Even though it's possible now to define custom session key generators you shouldn't use this hook, unless you really know what you do as this could compromise security if implemented improperly! The default built-in solution should usually fit any project.

@romshark romshark added feature request A server feature request, suggestion or proposal and removed feature request labels Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request A server feature request, suggestion or proposal
Projects
None yet
Development

No branches or pull requests

1 participant