Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime API annotations should probably be RetentionPolicy.CLASS (invisible) #113

Closed
dmlloyd opened this issue Dec 17, 2020 · 0 comments · Fixed by #632
Closed

Runtime API annotations should probably be RetentionPolicy.CLASS (invisible) #113

dmlloyd opened this issue Dec 17, 2020 · 0 comments · Fixed by #632
Labels
good first issue 🙂 An issue that could be a good starting point for potential contributors kind: bug 🪲 An error in the implementation code or documentation

Comments

@dmlloyd
Copy link
Collaborator

dmlloyd commented Dec 17, 2020

There's really no need to clutter the final image with these annotations. But it does mean that all of the plugin classes that are looking for these annotations in the visible set will have to be adjusted to looking in the invisible set instead.
@dmlloyd dmlloyd added the kind: bug 🪲 An error in the implementation code or documentation label Dec 17, 2020
@dmlloyd dmlloyd added the good first issue 🙂 An issue that could be a good starting point for potential contributors label Jun 15, 2021
@evacchi evacchi mentioned this issue Aug 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🙂 An issue that could be a good starting point for potential contributors kind: bug 🪲 An error in the implementation code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RetentionPolicy.CLASS (invisible set) for Runtime API annotations evacchi/qbicc
1 participant
@dmlloyd