Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about ignored elements #7

Open
geermc4 opened this issue Sep 7, 2012 · 2 comments
Open

warn about ignored elements #7

geermc4 opened this issue Sep 7, 2012 · 2 comments

Comments

@geermc4
Copy link

geermc4 commented Sep 7, 2012

Currently if you send a hash to hash_to_obj and it doesn't understand part of it, it just ignores it, it'd be nice if it logged it somewhere

@rposborne
Copy link
Contributor

I must +1 this, We discussed this a bit offline and think that either raising an exception or a warn message in a logger is pretty critical if non parsable data is being passed in.

I think it will let individuals be able to crush bad QBXML before they loose there mind. Because lets be real... we are not Quickbooks expert... some client just said ... can we integrate with quickbooks and we unwittingly said yes.

@geermc4
Copy link
Author

geermc4 commented Sep 11, 2012

This is even ignoring ones that are defined on the schema so this is now even more important -.- when trying to call ItemInventoryAddRq it barked at me cus' i didn't specify some fields, one of which was COGSAccountRef, after adding it, it still complained and then i noticed the field wasn't in the resulting XML

so i guess i'll probably be working on this one soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants