Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: custom provider #168

Closed
fredericrous opened this issue Feb 7, 2021 · 3 comments
Closed

Feature request: custom provider #168

fredericrous opened this issue Feb 7, 2021 · 3 comments
Assignees
Labels
Category: Documentation ✒️ A problem with the readme or in the docs/ directory Category: Good idea 🎯 This is a good idea, judged by the maintainers Category: New provider 🆕

Comments

@fredericrous
Copy link
Collaborator

  1. What's the feature?

Give users the ability to configure a custom provider. Looking at the current list of providers, I see a lot of providers are essentially calling one URL with a get request. We could give users the ability to define a url

{
    "settings": [
        {
            "provider": "custom",
            "domain": "example.com",
            "url": "https://someddns.service/update?domain=mondomain.fr&monToken=token&monIP",
            "displayName": "SomeDDNS"
        }
    ]
}
  1. Extra information?

We could go further by letting the user define a return code or to let him define HTTP headers, however in most cases the response seems to be 200 and no extra header is needed

The cons I see of implementing this is that we won't know which provider users are using (without some kind of anonymous analytics on which user could opt out)
The pros: less providers to implement, more providers supported by just documenting how to set them up

@fredericrous
Copy link
Collaborator Author

That's just a suggestion. As I'm using wildcard records with gandi and ovh I don't use this kind of paradigm. But I think that it could reduce the amount of code to maintain. And writing doc is sure less fun than coding but way faster ^^

@qdm12
Copy link
Owner

qdm12 commented Feb 8, 2021

A few of them use the dyndns protocol with tiny variations. We could tackle that 👍

But otherwise, it's highly variable between each provider and not just a GET request.

Repository owner deleted a comment from Jano69 Mar 21, 2021
Repository owner deleted a comment from Jano69 Mar 21, 2021
Repository owner deleted a comment from Jano69 Mar 21, 2021
Repository owner deleted a comment from Jano69 Apr 5, 2021
Repository owner deleted a comment from Jano69 Apr 5, 2021
Repository owner deleted a comment from Jano69 Apr 5, 2021
@qdm12 qdm12 added Category: Documentation ✒️ A problem with the readme or in the docs/ directory Category: New provider 🆕 Category: Good idea 🎯 This is a good idea, judged by the maintainers labels Jan 19, 2024
@qdm12
Copy link
Owner

qdm12 commented Jan 19, 2024

Done in 0c561d4

Documentation is at https://github.com/qdm12/ddns-updater/blob/master/docs/custom.md

It's sort of simple for now, but could be extended to some extent until implementing the provider specific code in Go would be simpler.

@qdm12 qdm12 closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation ✒️ A problem with the readme or in the docs/ directory Category: Good idea 🎯 This is a good idea, judged by the maintainers Category: New provider 🆕
Projects
None yet
Development

No branches or pull requests

2 participants