invalid domain name format "test.services" with docker

[marcuslannister]

It seams that it can not recognize "test.services" on config file, I change to "test.ser", then is ok.

here is my docker compose file, same as example.

version: "3.7"
services:
  ddns-updater:
    image: qmcgaw/ddns-updater
    container_name: ddns-updater
    network_mode: bridge
    ports:
      - 8000:8000/tcp
    volumes:
      - ./data:/updater/data
    environment:
      - CONFIG=
      - PERIOD=5m
      - IP_METHOD=cycle
      - IPV4_METHOD=cycle
      - IPV6_METHOD=cycle
      - HTTP_TIMEOUT=10s

      # Web UI
      - LISTENING_PORT=8000
      - ROOT_URL=/

      # Backup
      - BACKUP_PERIOD=0 # 0 to disable
      - BACKUP_DIRECTORY=/updater/data

      # Other
      - LOG_ENCODING=console
      - LOG_LEVEL=info
      - NODE_ID=-1 # -1 to disable
      - GOTIFY_URL=
      - GOTIFY_TOKEN=
    # restart: always
    restart: on-failure

[qdm12]

I'm not sure I understand your problem, can you please elaborate more? Thanks!

[marcuslannister]

sorry, I miss config file, below is my config file.

{
    "settings": [
        {
            "provider": "cloudflare",
            "domain": "test.services",
            "host": "@",
            "token": "xxx"
        }
    ]
}

when i start docker ddns-updater, it is fail.
fail log is

invalid domain name format "test.services"

when i change "domain": "test.services" to "domain": "test.ser", it is ok.

[qdm12]

That's because it uses this regex to verify the format of the domain. I'll update it to support more top level domain names, maybe remove it as well as it shouldn't be really useful. I'll do that tomorrow morning, thanks for your patience and for reporting the issue!

[marcuslannister]

got it and thanks.

[marcuslannister]

one more thing, could you please add he.net support? ^_^

[qdm12]

I removed the domain check so it should work with any domain name now. Anyway it's your responsibility to set the right domain name I guess 😄 Thanks again for the time creating the issue.