Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 / Angular 6 #326

Closed
Justus-Maier opened this issue Apr 4, 2018 · 7 comments
Closed

Webpack 4 / Angular 6 #326

Justus-Maier opened this issue Apr 4, 2018 · 7 comments

Comments

@Justus-Maier
Copy link

Changes should be basic, I have had some success with the @ngtools/webpack beta.6 without AT-loader..

@qdouble what are your plans on updating this starter?

@Justus-Maier
Copy link
Author

Maybe it would be possible to merge -aot.ts files with their non-aot correspondants? I've read about it, but haven't been successful removing them from an old setup.
E.g. this starter: https://github.com/wizardnet972/universal-seed does AOT compilation without those -aot.ts files.

@qdouble
Copy link
Owner

qdouble commented Apr 4, 2018

I haven't looked into it yet, but will start looking into it soon

@ElderJames
Copy link

Angular 6 and Material 6 have been released!

@qdouble
Copy link
Owner

qdouble commented May 31, 2018

@Justus-Maier @ElderJames It took me a while since I've been very busy, but I've updated Angular and Webpack. Just let me know if there are any issues.

@qdouble qdouble closed this as completed May 31, 2018
@Justus-Maier
Copy link
Author

Nice work! I will try it this week! :)

@Phoscur
Copy link

Phoscur commented Jun 11, 2018

got this when trying to run e2e tests:

E/launcher - Error: TSError: ⨯ Unable to compile TypeScript
e2e\app.e2e.ts (12,29): Argument of type 'string' is not assignable to parameter of type 'Expected<Promise<string>>'. (2345)
    at getOutput (C:\Projects\my-awesome-site\node_modules\ts-node\src\index.ts:330:15)
    at Object.compile (C:\Projects\my-awesome-site\node_modules\ts-node\src\index.ts:518:11)
    at Module.m._compile (C:\Projects\my-awesome-site\node_modules\ts-node\src\index.ts:403:43)
    at Module._extensions..js (module.js:660:10)
    at Object.require.extensions.(anonymous function) [as .ts] (C:\Projects\my-awesome-site\node_modules\ts-node\src\index.ts:406:12)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:501:12)
    at Function.Module._load (module.js:493:3)
    at Module.require (module.js:593:17)
    at require (internal/module.js:11:18)
[19:22:59] E/launcher - Process exited with error code 100

And there is still a server.aot.ts with "broken import" (vscode), and the sibling server.ts with an unused import. Can you merge those?
Related Question: What about a minimal-universal variant, that builds and deploys to github pages?
There is a lot undocumented npm commands, would be cool if there is one that renders a static website :)

@qdouble
Copy link
Owner

qdouble commented Jun 11, 2018

@Phoscur I'll try to look into the tests this week. I haven't really been able to use Universal in my real world apps, so that's why that has been lagging behind. I'll checkout the issues with it, but you can submit a pull request for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants