You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Timeout param type has been changed in QdrantClient from Optional[float] to Optional[int] to be on par with other timeouts.
Some users used to pass not supported httpx.Timeout, which allowed more fine-grained control over timeouts.
While I don't consider it to be a bad idea, it is doubtful for me whether we would like to explicitly add support for httpx.Timeout, or not, since it is not applicable to gRPC.
What can be painless at the moment is to ease the condition which prevents using types other than those allowed by math.ceil
While the decision has not been made yet, using types other than allowed by the interface is on the users risk
Hello @joein,
I feel this PR introduces a regression. We used to provide an httpx.Timeout object to our QdrantClient, which, although it wasn't compliant with the typings, allowed fine-grained timeout management between connect, read and write timeouts. Maybe it would be more appropriate to change the parameter type to Union[float, httpx.Timeout, None] and handle the types with dedicated logic in the constructor ?
@LouisAuneau unfortunately, we can't just ease the condition due to mypy complaints, we would need to do another workaround, but it won't be available in 1.7.2 :(
Timeout param type has been changed in
QdrantClient
fromOptional[float]
toOptional[int]
to be on par with other timeouts.Some users used to pass not supported
httpx.Timeout
, which allowed more fine-grained control over timeouts.While I don't consider it to be a bad idea, it is doubtful for me whether we would like to explicitly add support for
httpx.Timeout
, or not, since it is not applicable to gRPC.What can be painless at the moment is to ease the condition which prevents using types other than those allowed by
math.ceil
While the decision has not been made yet, using types other than allowed by the interface is on the users risk
Originally posted by @LouisAuneau in #443 (comment)
The text was updated successfully, but these errors were encountered: