Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Playwright tests #210

Closed
6 tasks done
Xpirix opened this issue Mar 8, 2024 · 0 comments
Closed
6 tasks done

Improve the Playwright tests #210

Xpirix opened this issue Mar 8, 2024 · 0 comments

Comments

@Xpirix
Copy link
Collaborator

Xpirix commented Mar 8, 2024

Tools

Playwright CI tests

Summary

Tools

Playwright CI tests

Summary

Kontur's suggestions about the playwright CI test:

  1. Initially, all locators should be placed within a page object dedicated to a specific page. Then, a property of the object should be called in the test. In case of changes on the website, the only need would be then to modify the locator in this object, without touching the test itself. There should be a base page containing global methods and locators common to all pages, such as footer and header. Other page objects should inherit from this base page. Currently, some commands and selectors are repeated for each test, which could be avoided.
  2. Timeout parameters need to be added to all expectations. Currently, it seems to wait for 5 seconds and then fail. The issue is that the browser, especially in CI, might freeze (which is not noticeable when manually accessing the site). Therefore, 5 seconds might not be sufficient; the timeout limit should be increased to 10-15 seconds and adjusted as needed.
  3. It is critically important to divide the 500 lines of checks in a test into parts, where one test checks one aspect and another test checks another. In the current implementation, if a test fails midway, the engine won't even reach the end, making it hard to fix. Such big tests should be divided into at least 15 parts to provide better maintainability and reporting. Also better think about sync and async checks not to depend on the checks that are not relevant to the current test scenario.
  • Homepage with header and footer
  • Download page
  • Product page
  • Community page
  • Resources page
  • Funding page
@Xpirix Xpirix changed the title Improve the Playwright test Improve the Playwright tests Mar 8, 2024
@Xpirix Xpirix closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant