Fix georeferencer help button

src/app/georeferencer/qgsgeorefmainwindow.cpp

@@ -681,12 +681,6 @@ void QgsGeoreferencerMainWindow::localHistogramStretch()
   mCanvas->refresh();
 }
 
-// Info slots
-void QgsGeoreferencerMainWindow::showHelp()
-{
-  QgsHelp::openHelp( QStringLiteral( "plugins/core_plugins/plugins_georeferencer.html#defining-the-transformation-settings" ) );
-}
-
 // Comfort slots
 void QgsGeoreferencerMainWindow::jumpToGCP( uint theGCPIndex )
 {
@@ -905,10 +899,6 @@ void QgsGeoreferencerMainWindow::createActions()
   connect( mActionFullHistogramStretch, &QAction::triggered, this, &QgsGeoreferencerMainWindow::fullHistogramStretch );
   mActionFullHistogramStretch->setEnabled( false );
 
-  // Help actions
-  mActionHelp = new QAction( tr( "Help" ), this );
-  connect( mActionHelp, &QAction::triggered, this, &QgsGeoreferencerMainWindow::showHelp );
-
   mActionQuit->setShortcuts( QList<QKeySequence>() << QKeySequence( Qt::CTRL + Qt::Key_Q )
                              << QKeySequence( Qt::Key_Escape ) );
   connect( mActionQuit, &QAction::triggered, this, &QWidget::close );

src/app/georeferencer/qgsgeorefmainwindow.h

@@ -101,9 +101,6 @@ class QgsGeoreferencerMainWindow : public QMainWindow, private Ui::QgsGeorefPlug
     void showRasterPropertiesDialog();
     void showGeorefConfigDialog();
 
-    // plugin info
-    void showHelp();
-
     // comfort
     void jumpToGCP( uint theGCPIndex );
     void extentsChangedGeorefCanvas();
@@ -205,8 +202,6 @@ class QgsGeoreferencerMainWindow : public QMainWindow, private Ui::QgsGeorefPlug
     QMenu *mPanelMenu = nullptr;
     QMenu *mToolbarMenu = nullptr;
 
-    QAction *mActionHelp = nullptr;
-
     QgsGCPListWidget *mGCPListWidget = nullptr;
     QLineEdit *mScaleEdit = nullptr;
     QLabel *mScaleLabel = nullptr;

src/app/georeferencer/qgstransformsettingsdialog.cpp

@@ -25,6 +25,7 @@
 #include "qgstransformsettingsdialog.h"
 #include "qgscoordinatereferencesystem.h"
 #include "qgsgui.h"
+#include "qgshelp.h"
 
 QgsTransformSettingsDialog::QgsTransformSettingsDialog( const QString &raster, const QString &output,
     int countGCPpoints, QWidget *parent )
@@ -124,6 +125,7 @@ QgsTransformSettingsDialog::QgsTransformSettingsDialog( const QString &raster, c
   cbxLoadInQgisWhenDone->setChecked( settings.value( QStringLiteral( "/Plugin-GeoReferencer/loadinqgis" ), false ).toBool() );
   saveGcpCheckBox->setChecked( settings.value( QStringLiteral( "/Plugin-GeoReferencer/save_gcp_points" ), false ).toBool() );
 
+  connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsTransformSettingsDialog::showHelp );
 }
 
 void QgsTransformSettingsDialog::getTransformSettings( QgsGeorefTransform::TransformParametrisation &tp,
@@ -310,3 +312,8 @@ QIcon QgsTransformSettingsDialog::getThemeIcon( const QString &name )
     }
   }
 }
+
+void QgsTransformSettingsDialog::showHelp()
+{
+  QgsHelp::openHelp( QStringLiteral( "working_with_raster/georeferencer.html#defining-the-transformation-settings" ) );
+}

src/app/georeferencer/qgstransformsettingsdialog.h

@@ -44,6 +44,7 @@ class QgsTransformSettingsDialog : public QDialog, private Ui::QgsTransformSetti
     void cmbTransformType_currentIndexChanged( const QString &text );
     void mWorldFileCheckBox_stateChanged( int state );
     QIcon getThemeIcon( const QString &name );
+    void showHelp();
 
   private:
     bool checkGCPpoints( int count, int &minGCPpoints );