Fix the issues with QTimer start/stop in different thread

qgis · Feb 28, 2014 · 2081fc9 · 2081fc9
1 parent 9b893a3
commit 2081fc9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/src/core/qgsconnectionpool.h b/src/core/qgsconnectionpool.h
@@ -43,6 +43,9 @@
  * - being derived from QObject
  * - calling initTimer( this ) in constructor
  * - having handleConnectionExpired() slot that calls onConnectionExpired()
+ * - having startExpirationTimer(), stopExpirationTimer() slots to start/stop the expiration timer
+ *
+ * For an example on how to use the template class, have a look at the implementation in postgres/spatialite providers.
  */
 template <typename T>
 class QgsConnectionPoolGroup
@@ -88,10 +91,8 @@ class QgsConnectionPoolGroup
           // no need to run if nothing can expire
           if ( conns.isEmpty() )
           {
-            if ( QThread::currentThread() == qApp->thread() )
+            // will call the slot directly or queue the call (if the object lives in a different thread)
-              expirationTimer->stop();
+            QMetaObject::invokeMethod( expirationTimer->parent(), "stopExpirationTimer" );
-            else
-              QgsDebugMsg( "expirationTimer not stopped from thread" );  // TODO use signals in that case?
           }
 
           return i.c;
@@ -120,10 +121,8 @@ class QgsConnectionPoolGroup
 
       if ( !expirationTimer->isActive() )
       {
-        if ( QThread::currentThread() == qApp->thread() )
+        // will call the slot directly or queue the call (if the object lives in a different thread)
-          expirationTimer->start();
+        QMetaObject::invokeMethod( expirationTimer->parent(), "startExpirationTimer" );
-        else
-          QgsDebugMsg( "expirationTimer not started from thread" );  // TODO use signals in that case?
       }
 
       connMutex.unlock();

diff --git a/src/providers/postgres/qgspostgresconnpool.h b/src/providers/postgres/qgspostgresconnpool.h
@@ -46,6 +46,8 @@ class QgsPostgresConnPoolGroup : public QObject, public QgsConnectionPoolGroup<Q
 
   protected slots:
     void handleConnectionExpired() { onConnectionExpired(); }
+    void startExpirationTimer() { expirationTimer->start(); }
+    void stopExpirationTimer() { expirationTimer->stop(); }
 
   protected:
     Q_DISABLE_COPY( QgsPostgresConnPoolGroup )

diff --git a/src/providers/spatialite/qgsspatialiteconnpool.h b/src/providers/spatialite/qgsspatialiteconnpool.h
@@ -45,6 +45,8 @@ class QgsSpatiaLiteConnPoolGroup : public QObject, public QgsConnectionPoolGroup
 
   protected slots:
     void handleConnectionExpired() { onConnectionExpired(); }
+    void startExpirationTimer() { expirationTimer->start(); }
+    void stopExpirationTimer() { expirationTimer->stop(); }
 
   protected:
     Q_DISABLE_COPY( QgsSpatiaLiteConnPoolGroup )