Use QgsFields::rename instead of QgsField::setName when modifying the…

… name of a field inside an existing QgsFields. This is done to avoid corruption of internal nameToIndex data structure.
qgis · Jan 23, 2020 · 2540f0f · 2540f0f
1 parent 2ddcf00
commit 2540f0f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/analysis/processing/qgsalgorithmjoinbyattribute.cpp b/src/analysis/processing/qgsalgorithmjoinbyattribute.cpp
@@ -154,7 +154,7 @@ QVariantMap QgsJoinByAttributeAlgorithm::processAlgorithm( const QVariantMap &pa
   {
     for ( int i = 0; i < outFields2.count(); ++i )
     {
-      outFields2[ i ].setName( prefix + outFields2[ i ].name() );
+      outFields2.rename( i, prefix + outFields2[ i ].name() );
     }
   }
 

diff --git a/src/analysis/processing/qgsalgorithmjoinbylocation.cpp b/src/analysis/processing/qgsalgorithmjoinbylocation.cpp
@@ -159,7 +159,7 @@ QVariantMap QgsJoinByLocationAlgorithm::processAlgorithm( const QVariantMap &par
   {
     for ( int i = 0; i < joinFields.count(); ++i )
     {
-      joinFields[ i ].setName( prefix + joinFields[ i ].name() );
+      joinFields.rename( i, prefix + joinFields[ i ].name() );
     }
   }
 

diff --git a/src/analysis/processing/qgsalgorithmjoinbynearest.cpp b/src/analysis/processing/qgsalgorithmjoinbynearest.cpp
@@ -160,7 +160,7 @@ QVariantMap QgsJoinByNearestAlgorithm::processAlgorithm( const QVariantMap &para
   {
     for ( int i = 0; i < outFields2.count(); ++i )
     {
-      outFields2[ i ].setName( prefix + outFields2[ i ].name() );
+      outFields2.rename( i, prefix + outFields2[ i ].name() );
     }
   }
 

diff --git a/src/analysis/processing/qgsalgorithmrenametablefield.cpp b/src/analysis/processing/qgsalgorithmrenametablefield.cpp
@@ -90,7 +90,7 @@ QgsFields QgsRenameTableFieldAlgorithm::outputFields( const QgsFields &inputFiel
   if ( outFields.lookupField( mNewName ) >= 0 )
     throw QgsProcessingException( QObject::tr( "A field already exists with the name %1" ).arg( mNewName ) );
 
-  outFields[ index ].setName( mNewName );
+  outFields.rename( index, mNewName );
   return outFields;
 }
 

diff --git a/src/core/qgsvectorlayerexporter.cpp b/src/core/qgsvectorlayerexporter.cpp
@@ -276,7 +276,7 @@ QgsVectorLayerExporter::exportLayer( QgsVectorLayer *layer,
     // convert field names to lowercase
     for ( int fldIdx = 0; fldIdx < fields.count(); ++fldIdx )
     {
-      fields[fldIdx].setName( fields.at( fldIdx ).name().toLower() );
+      fields.rename( fldIdx, fields.at( fldIdx ).name().toLower() );
     }
   }