Skip to content

Commit

Permalink
WMS provider: use 'WMS/WMTS' instead of 'WMS' in various UI labels (f…
Browse files Browse the repository at this point in the history
…ixes #18883)
  • Loading branch information
rouault committed May 24, 2018
1 parent dde895d commit 3e43609
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
9 changes: 8 additions & 1 deletion src/gui/qgsnewhttpconnection.cpp
Expand Up @@ -36,7 +36,14 @@ QgsNewHttpConnection::QgsNewHttpConnection( QWidget *parent, ConnectionTypes typ


QRegExp rx( "/connections-([^/]+)/" ); QRegExp rx( "/connections-([^/]+)/" );
if ( rx.indexIn( baseKey ) != -1 ) if ( rx.indexIn( baseKey ) != -1 )
setWindowTitle( tr( "Create a New %1 Connection" ).arg( rx.cap( 1 ).toUpper() ) ); {
QString connectionType( rx.cap( 1 ).toUpper() );
if ( connectionType == QLatin1String( "WMS" ) )
{
connectionType = QStringLiteral( "WMS/WMTS" );
}
setWindowTitle( tr( "Create a New %1 Connection" ).arg( connectionType ) );
}


// It would be obviously much better to use mBaseKey also for credentials, // It would be obviously much better to use mBaseKey also for credentials,
// but for some strange reason a different hardcoded key was used instead. // but for some strange reason a different hardcoded key was used instead.
Expand Down
4 changes: 2 additions & 2 deletions src/providers/wms/qgswmsdataitems.cpp
Expand Up @@ -422,7 +422,7 @@ QgsDataItem *QgsWmsDataItemProvider::createDataItem( const QString &path, QgsDat
QgsDebugMsg( "path = " + path ); QgsDebugMsg( "path = " + path );
if ( path.isEmpty() ) if ( path.isEmpty() )
{ {
return new QgsWMSRootItem( parentItem, QStringLiteral( "WMS" ), QStringLiteral( "wms:" ) ); return new QgsWMSRootItem( parentItem, QStringLiteral( "WMS/WMTS" ), QStringLiteral( "wms:" ) );
} }


// path schema: wms:/connection name (used by OWS) // path schema: wms:/connection name (used by OWS)
Expand All @@ -432,7 +432,7 @@ QgsDataItem *QgsWmsDataItemProvider::createDataItem( const QString &path, QgsDat
if ( QgsWMSConnection::connectionList().contains( connectionName ) ) if ( QgsWMSConnection::connectionList().contains( connectionName ) )
{ {
QgsWMSConnection connection( connectionName ); QgsWMSConnection connection( connectionName );
return new QgsWMSConnectionItem( parentItem, QStringLiteral( "WMS" ), path, connection.uri().encodedUri() ); return new QgsWMSConnectionItem( parentItem, QStringLiteral( "WMS/WMTS" ), path, connection.uri().encodedUri() );
} }
} }


Expand Down
2 changes: 1 addition & 1 deletion src/providers/wms/qgswmsprovider.cpp
Expand Up @@ -4240,7 +4240,7 @@ class QgsWmsSourceSelectProvider : public QgsSourceSelectProvider
public: public:


QString providerKey() const override { return QStringLiteral( "wms" ); } QString providerKey() const override { return QStringLiteral( "wms" ); }
QString text() const override { return QObject::tr( "WMS" ); } QString text() const override { return QObject::tr( "WMS/WMTS" ); }
int ordering() const override { return QgsSourceSelectProvider::OrderRemoteProvider + 10; } int ordering() const override { return QgsSourceSelectProvider::OrderRemoteProvider + 10; }
QIcon icon() const override { return QgsApplication::getThemeIcon( QStringLiteral( "/mActionAddWmsLayer.svg" ) ); } QIcon icon() const override { return QgsApplication::getThemeIcon( QStringLiteral( "/mActionAddWmsLayer.svg" ) ); }
QgsAbstractDataSourceWidget *createDataSourceWidget( QWidget *parent = nullptr, Qt::WindowFlags fl = Qt::Widget, QgsProviderRegistry::WidgetMode widgetMode = QgsProviderRegistry::WidgetMode::Embedded ) const override QgsAbstractDataSourceWidget *createDataSourceWidget( QWidget *parent = nullptr, Qt::WindowFlags fl = Qt::Widget, QgsProviderRegistry::WidgetMode widgetMode = QgsProviderRegistry::WidgetMode::Embedded ) const override
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsnewhttpconnectionbase.ui
Expand Up @@ -118,7 +118,7 @@
<item row="3" column="0" colspan="2"> <item row="3" column="0" colspan="2">
<widget class="QGroupBox" name="mWmsOptionsGroupBox"> <widget class="QGroupBox" name="mWmsOptionsGroupBox">
<property name="title"> <property name="title">
<string>WMS Options</string> <string>WMS/WMTS Options</string>
</property> </property>
<layout class="QGridLayout" name="gridLayout_2"> <layout class="QGridLayout" name="gridLayout_2">
<item row="5" column="0" colspan="2"> <item row="5" column="0" colspan="2">
Expand Down

0 comments on commit 3e43609

Please sign in to comment.