[3d] fix inevitable crashes when terrain bounding boxes were shown

The list of vertices just kept growing and growing (and we didn't even need another copy!)
qgis · Nov 8, 2018 · 528c8a6 · 528c8a6
1 parent 222f0a0
commit 528c8a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/3d/chunks/qgschunkboundsentity_p.cpp b/src/3d/chunks/qgschunkboundsentity_p.cpp
@@ -48,9 +48,9 @@ void LineMeshGeometry::setVertices( const QList<QVector3D> &vertices )
     rawVertexArray[idx++] = v.x();
     rawVertexArray[idx++] = v.y();
     rawVertexArray[idx++] = v.z();
-    mVertices.append( v );
   }
 
+  mVertexCount = vertices.count();
   mVertexBuffer->setData( vertexBufferData );
 }
 

diff --git a/src/3d/chunks/qgschunkboundsentity_p.h b/src/3d/chunks/qgschunkboundsentity_p.h
@@ -67,15 +67,15 @@ class LineMeshGeometry : public Qt3DRender::QGeometry
 
     int vertexCount()
     {
-      return mVertices.size();
+      return mVertexCount;
     }
 
     void setVertices( const QList<QVector3D> &vertices );
 
   private:
     Qt3DRender::QAttribute *mPositionAttribute = nullptr;
     Qt3DRender::QBuffer *mVertexBuffer = nullptr;
-    QList<QVector3D> mVertices;
+    int mVertexCount = 0;
 
 };