allow to reset prefixes in settings

qgis · May 10, 2018 · 6459d24 · 6459d24
1 parent 0a0de2e
commit 6459d24
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 33 deletions.
diff --git a/python/core/locator/qgslocator.sip.in b/python/core/locator/qgslocator.sip.in
@@ -73,23 +73,13 @@ deregisterFilter() to deregister their filters upon plugin unload to avoid crash
 .. seealso:: :py:func:`registerFilter`
 %End
 
-    QList< QgsLocatorFilter *> filters( const QString &prefix = QString() );
+    QList< QgsLocatorFilter *> filters();
 %Docstring
 Returns the list of filters registered in the locator.
 
 .. seealso:: :py:func:`prefixedFilters`
 %End
 
-    QStringList prefixes();
-%Docstring
-Returns the list of prefixes in use.
-A prefix can have several filters
-
-.. seealso:: :py:func:`filter`
-
-.. versionadded:: 3.2
-%End
-
 
  QMap<QString, QgsLocatorFilter *> prefixedFilters() const;
 %Docstring

diff --git a/src/app/locator/qgslocatoroptionswidget.cpp b/src/app/locator/qgslocatoroptionswidget.cpp
@@ -178,9 +178,15 @@ bool QgsLocatorFiltersModel::setData( const QModelIndex &index, const QVariant &
         case Prefix:
         {
           QString prefix = value.toString();
-          if ( prefix.isEmpty() )
+          if ( !prefix.isEmpty() )
-            return false;
+          {
-          mPrefixes.insert( filterForIndex( index ), prefix );
+            mPrefixes.insert( filterForIndex( index ), prefix );
+          }
+          else
+          {
+            // reset to the native prefix
+            mPrefixes.insert( filterForIndex( index ), filterForIndex( index )->prefix() );
+          }
           emit dataChanged( index, index );
           return true;
         }

diff --git a/src/core/locator/qgslocator.cpp b/src/core/locator/qgslocator.cpp
@@ -48,17 +48,9 @@ void QgsLocator::deregisterFilter( QgsLocatorFilter *filter )
   delete filter;
 }
 
-QList<QgsLocatorFilter *> QgsLocator::filters( const QString &prefix )
+QList<QgsLocatorFilter *> QgsLocator::filters()
 {
-  if ( !prefix.isEmpty() )
+  return mFilters;
-    return mPrefixedFilters.values( prefix );
-  else
-    return mFilters;
-}
-
-QStringList QgsLocator::prefixes()
-{
-  return mPrefixedFilters.keys();
 }
 
 QMultiMap<QString, QgsLocatorFilter *> QgsLocator::prefixedFilters() const

diff --git a/src/core/locator/qgslocator.h b/src/core/locator/qgslocator.h
@@ -60,6 +60,7 @@ class CORE_EXPORT QgsLocator : public QObject
 
   public:
 
+    //! List of core filters (i.e. not plugin filters)
     static const QList<QString> CORE_FILTERS;
 
     /**
@@ -96,15 +97,7 @@ class CORE_EXPORT QgsLocator : public QObject
      * Returns the list of filters registered in the locator.
      * \see prefixedFilters()
      */
-    QList< QgsLocatorFilter *> filters( const QString &prefix = QString() );
+    QList< QgsLocatorFilter *> filters();
-
-    /**
-     * Returns the list of prefixes in use.
-     * A prefix can have several filters
-     * \see filter()
-     * \since QGIS 3.2
-     */
-    QStringList prefixes();
 
 #ifndef SIP_RUN