Fix cppcheck uninitMemberVar warnings in src/core/

Found with ~/cppcheck/cppcheck --enable=all --inconclusive ../src/core --library=$HOME/cppcheck/cfg/qt.cfg -j 8 -DSIP_OUT 2>&1 | grep uninitMemberVar
qgis · Jan 30, 2020 · 7af8f8f · 7af8f8f
1 parent ed3e0d9
commit 7af8f8f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/src/core/diagram/qgsdiagram.cpp b/src/core/diagram/qgsdiagram.cpp
@@ -17,9 +17,8 @@
 
 #include <QPainter>
 
-QgsDiagram::QgsDiagram( const QgsDiagram &other )
+QgsDiagram::QgsDiagram( const QgsDiagram & ): mExpressions{}
 {
-  Q_UNUSED( other )
   // do not copy the cached expression map - the expressions need to be created and prepared with getExpression(...) call
 }
 

diff --git a/src/core/effects/qgsgloweffect.cpp b/src/core/effects/qgsgloweffect.cpp
@@ -33,6 +33,8 @@ QgsGlowEffect::QgsGlowEffect( const QgsGlowEffect &other )
   , mSpreadUnit( other.spreadUnit() )
   , mSpreadMapUnitScale( other.spreadMapUnitScale() )
   , mBlurLevel( other.blurLevel() )
+  , mBlurUnit( other.mBlurUnit )
+  , mBlurMapUnitScale( other.mBlurMapUnitScale )
   , mOpacity( other.opacity() )
   , mColor( other.color() )
   , mBlendMode( other.blendMode() )

diff --git a/src/core/expression/qgsexpressioncontextutils.h b/src/core/expression/qgsexpressioncontextutils.h
@@ -327,7 +327,7 @@ class CORE_EXPORT QgsExpressionContextUtils
 
         QList< QPointer< QgsMapLayer > > mLayers;
         QMap< QPointer< QgsMapLayer >, QPair< double, double > > mScaleBasedVisibilityDetails;
-        double mScale;
+        double mScale = 0.0;
 
     };
 

diff --git a/src/core/qgsexpressioncontext.cpp b/src/core/qgsexpressioncontext.cpp
@@ -237,7 +237,7 @@ QgsExpressionContext::QgsExpressionContext( const QList<QgsExpressionContextScop
 {
 }
 
-QgsExpressionContext::QgsExpressionContext( const QgsExpressionContext &other )
+QgsExpressionContext::QgsExpressionContext( const QgsExpressionContext &other ) : mStack{}
 {
   for ( const QgsExpressionContextScope *scope : qgis::as_const( other.mStack ) )
   {

diff --git a/src/core/qgsfeaturerequest.cpp b/src/core/qgsfeaturerequest.cpp
@@ -56,7 +56,7 @@ QgsFeatureRequest::QgsFeatureRequest( const QgsExpression &expr, const QgsExpres
 {
 }
 
-QgsFeatureRequest::QgsFeatureRequest( const QgsFeatureRequest &rh )
+QgsFeatureRequest::QgsFeatureRequest( const QgsFeatureRequest &rh ): mTransformContext{}
 {
   operator=( rh );
 }