[ci] Run shellcheck as part of code_layout build

qgis · Jun 21, 2018 · 7d938e8 · 7d938e8
1 parent 481461d
commit 7d938e8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/tests/code_layout/CMakeLists.txt b/tests/code_layout/CMakeLists.txt
@@ -6,6 +6,7 @@ ADD_TEST(qgis_banned_keywords ${CMAKE_SOURCE_DIR}/tests/code_layout/test_banned_
 ADD_TEST(qgis_licenses ${CMAKE_SOURCE_DIR}/tests/code_layout/test_licenses.sh)
 ADD_TEST(qgis_spelling ${CMAKE_SOURCE_DIR}/scripts/spell_check/spell_test.sh)
 
+ADD_TEST(qgis_shellcheck ${CMAKE_SOURCE_DIR}/tests/code_layout/test_shellcheck.sh)
 ADD_TEST(qgis_sipify ${CMAKE_SOURCE_DIR}/tests/code_layout/test_sipify.sh)
 ADD_TEST(qgis_sip_include ${CMAKE_SOURCE_DIR}/tests/code_layout/test_sip_include.sh)
 ADD_TEST(qgis_sip_uptodate ${CMAKE_SOURCE_DIR}/tests/code_layout/test_sipfiles_uptodate.sh)

diff --git a/tests/code_layout/test_shellcheck.sh b/tests/code_layout/test_shellcheck.sh
@@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+
+# This runs shellcheck on all sh files
+
+DIR=$(git rev-parse --show-toplevel)
+
+pushd ${DIR} > /dev/null
+result=$(shellcheck $(find . -name '*.sh'))
+popd > /dev/null
+
+if [[ $result ]]; then
+  echo " *** shellcheck found script errors"
+  echo "$result"
+  exit 1
+fi