Skip to content

Commit

Permalink
Ensure that ept provider is the preferred provider for ept.json files
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Nov 4, 2020
1 parent 0ebe788 commit eb6e53d
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/core/providers/ept/qgseptprovider.cpp
Expand Up @@ -90,6 +90,16 @@ QList<QgsDataItemProvider *> QgsEptProviderMetadata::dataItemProviders() const
return providers; return providers;
} }


int QgsEptProviderMetadata::priorityForUri( const QString &uri )
{
const QVariantMap parts = decodeUri( uri );
QFileInfo fi( parts.value( QStringLiteral( "path" ) ).toString() );
if ( fi.fileName().compare( QLatin1String( "ept.json" ), Qt::CaseInsensitive ) == 0 )
return 100;

return 0;
}

QVariantMap QgsEptProviderMetadata::decodeUri( const QString &uri ) QVariantMap QgsEptProviderMetadata::decodeUri( const QString &uri )
{ {
const QString path = uri; const QString path = uri;
Expand Down
1 change: 1 addition & 0 deletions src/core/providers/ept/qgseptprovider.h
Expand Up @@ -63,6 +63,7 @@ class QgsEptProviderMetadata : public QgsProviderMetadata
QgsEptProviderMetadata(); QgsEptProviderMetadata();
QgsEptProvider *createProvider( const QString &uri, const QgsDataProvider::ProviderOptions &options, QgsDataProvider::ReadFlags flags = QgsDataProvider::ReadFlags() ) override; QgsEptProvider *createProvider( const QString &uri, const QgsDataProvider::ProviderOptions &options, QgsDataProvider::ReadFlags flags = QgsDataProvider::ReadFlags() ) override;
QList< QgsDataItemProvider * > dataItemProviders() const override; QList< QgsDataItemProvider * > dataItemProviders() const override;
int priorityForUri( const QString &uri ) override;
QString encodeUri( const QVariantMap &parts ) override; QString encodeUri( const QVariantMap &parts ) override;
QVariantMap decodeUri( const QString &uri ) override; QVariantMap decodeUri( const QString &uri ) override;
QString filters( FilterType type ) override; QString filters( FilterType type ) override;
Expand Down
8 changes: 8 additions & 0 deletions tests/src/providers/testqgseptprovider.cpp
Expand Up @@ -46,6 +46,7 @@ class TestQgsEptProvider : public QObject
void filters(); void filters();
void encodeUri(); void encodeUri();
void decodeUri(); void decodeUri();
void preferredUri();


private: private:
QString mTestDataDir; QString mTestDataDir;
Expand Down Expand Up @@ -108,6 +109,13 @@ void TestQgsEptProvider::decodeUri()
QCOMPARE( parts.value( QStringLiteral( "path" ) ).toString(), QStringLiteral( "/home/point_clouds/ept.json" ) ); QCOMPARE( parts.value( QStringLiteral( "path" ) ).toString(), QStringLiteral( "/home/point_clouds/ept.json" ) );
} }


void TestQgsEptProvider::preferredUri()
{
// test that EPT is the preferred provider for ept.json uris
QCOMPARE( QgsProviderRegistry::instance()->preferredProviderForUri( QStringLiteral( "/home/test/ept.json" ) )->key(), QStringLiteral( "ept" ) );
QCOMPARE( QgsProviderRegistry::instance()->preferredProviderForUri( QStringLiteral( "/home/test/EPT.JSON" ) )->key(), QStringLiteral( "ept" ) );
}



QGSTEST_MAIN( TestQgsEptProvider ) QGSTEST_MAIN( TestQgsEptProvider )
#include "testqgseptprovider.moc" #include "testqgseptprovider.moc"

0 comments on commit eb6e53d

Please sign in to comment.