Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify tool: features highlited wrong when a polygon inside a polygon is presnt #10985

Closed
qgib opened this issue Jan 30, 2008 · 9 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats)
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Jan 30, 2008

Author Name: Maciej Sieczka - (Maciej Sieczka -)
Original Redmine Issue: 926

Redmine category:vectors
Assignee: Tim Sutton


Look at the attached screendumps.

Black arrow points at the polygon being queried.

identify_bad.png shows how it is now. This is wrong - although the smaller polygon inside is not being queried, it looks like if it was too.

identify_ok.png shows how it should look like - it is clear which polygon is queried actually.


@qgib
Copy link
Contributor Author

qgib commented Jul 8, 2008

Author Name: Tim Sutton (Tim Sutton)


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Jul 9, 2008

Author Name: Tim Sutton (Tim Sutton)


I had a detailed look at this. The issue lies inside [[QgsRubberBand]]. The polygon drawing routine in that class iterates over multipolygons, but not rings. It will be possible to add this functionality (and I agree we should) but I dont think its a good idea to make the invasive changes required right at the end of code freeze / on the point of release. I'm moving this issue over to milestone 1.0.0 and I'll attend to it in the next release cycle.

Regards

Tim

@qgib
Copy link
Contributor Author

qgib commented Jun 29, 2009

Author Name: Giovanni Manghi (@gioman)


Hi,
I gave a try to this on qgis 1.2 (rev. 10988).

If the select tool is used on the outer polygon it selects just it, using the tool on the inner one, it selects both.

This means that this bug has already been fixed?

@qgib
Copy link
Contributor Author

qgib commented Jul 8, 2009

Author Name: Giovanni Manghi (@gioman)


I noticed that by selecting the proper row (the one of the inner polygon) in the attribute table, it possible to select just the inner or the outer polygon. The select tools does not behave the same, so I guess this is still to fix. Nevertheless should be easy. Pushing the milestone to 1.2.

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2009

Author Name: Giovanni Manghi (@gioman)


Well,

if Qgis is doing it wrong it is not alone. I just tested gvSIG 1.2 and it behaves exactly the same way (see may last two comments).

So, please leave feedback, if this is the right behaviour we can close the ticket.

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2009

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from In Progress to Open

@qgib
Copy link
Contributor Author

qgib commented Dec 8, 2009

Author Name: Giovanni Manghi (@gioman)


I believe that this can be closed now. See attached screenshots to see how it worls the identify tool now.

Clicking on the outer polygon it kind of highlight also the inner one, but the result window do not show it. Moreover if you click again on the inner polygon it will get a more dense color and the result appear in the result windows.

Then if you click on the proper result in the result window you'll get highlighted just the inner one.


  • status_id was changed from Open to Closed
  • resolution was changed from to fixed

@qgib
Copy link
Contributor Author

qgib commented Mar 2, 2011

Author Name: Ivan Mincik (Ivan Mincik)


I am reopening this ticket, because of the behavior of 'identify tool' in current trunk which is the same as in 'identify_bad.png' picture.

Ticket #12250 is duplicate to this issue.
There was also thread in mailinglist r1.

r1 - http://www.mail-archive.com/qgis-developer@lists.osgeo.org/msg02031.html


  • status_id was changed from Closed to Feedback
  • resolution was changed from fixed to

@qgib
Copy link
Contributor Author

qgib commented Mar 2, 2011

Author Name: Jürgen Fischer (@jef-n)


fixed in 15315.


  • resolution was changed from to fixed
  • status_id was changed from Feedback to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats) labels May 24, 2019
@qgib qgib added this to the Version 1.7.0 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Development

No branches or pull requests

1 participant