Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topological editing with snapping to segment yields 2 vertices instead of 1 adding vertex #11037

Closed
qgib opened this issue Mar 8, 2008 · 10 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality

Comments

@qgib
Copy link
Contributor

qgib commented Mar 8, 2008

Author Name: Maciej Sieczka - (Maciej Sieczka -)
Original Redmine Issue: 978

Redmine category:digitising
Assignee: Tim Sutton


  1. Add a line or polygon Shapefile or [[PostGIS]] layer.

  2. In project properties enable topological editing, set snapping mode "to segment" or "to vertex and segment".

  3. Digitize a line or boundary.

  4. Add a vertex on it, move it - you see 2 vertices were added instead of 1. Topology broken.

SVN r8190.


@qgib
Copy link
Contributor Author

qgib commented Apr 16, 2008

Author Name: Maciej Sieczka - (Maciej Sieczka -)


Still valid as of b528687 (SVN r8353).

@qgib
Copy link
Contributor Author

qgib commented Jul 8, 2008

Author Name: Tim Sutton (Tim Sutton)


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Jul 9, 2008

Author Name: Tim Sutton (Tim Sutton)


Cant replicate. I created a new line using the 'lines' layer in tests/testdata. Digitised a line across one of the roads with a vertex snapped to the road I was crossing. When I subsequently move the vertex, 4 red guides appear and both features are modified in shape as I drag the vertex around.

I'm marking this as 'works for me'. Please advise with more detail if there is something I'm missing and we can adjust the status of the ticket accordingly.

Regards

Tim


  • status_id was changed from In Progress to Closed
  • resolution was changed from to worksforme

@qgib
Copy link
Contributor Author

qgib commented Jul 9, 2008

Author Name: Maciej Sieczka - (Maciej Sieczka -)


Tim

You need to set snapping different than 0 for the given layer to notice the bug.

The greater snapping threshold, the greater chance of reproducing the error - at 10 I have 100% "success" of adding 3 vertices instead of 1 in a line Shapefile layer.

Please please fix it before release.


  • resolution was changed from worksforme to
  • status_id was changed from Closed to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jul 9, 2008

Author Name: Tim Sutton (Tim Sutton)


Hi

Ah ok - I had tested at 1 and at 0.1 and it was working ok - will retest.

Regards

Tim

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2008

Author Name: Tim Sutton (Tim Sutton)


I still cant replicate this issue. Could you send me a small dataset to test with that will allow me to replicate?

If I cant replicate and resolve this tomorrow I am going to push this bug over to 1.0.0 milestone.

Regards

Tim

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2008

Author Name: Maciej Sieczka - (Maciej Sieczka -)


Tim,

I can still reproduce the bug in latest trunk 3009c0b (SVN r8751). Follow this please:

  1. Open the attached shapefile in QGIS.

  2. Project properties: check "Enable topological editing".

  3. Project properties > Snapping options: check the layer, Mode: "to vertex and segment", Tolerance: "10".

  4. Toggle editing.

  5. Add a vertex, move it - you'll see 3 vertices were added instead of 1. The attached screendumps show that it really happens.

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2008

Author Name: Tim Sutton (Tim Sutton)


Hi

Ah great thanks for that I can replicate the issue now.

Regards

Tim

@qgib
Copy link
Contributor Author

qgib commented Jul 11, 2008

Author Name: Marco Hugentobler (@mhugent)


This should be fixed in 6972f69 (SVN r8754).
Please test and reopen the bug if you still have the problem


  • status_id was changed from Feedback to Closed
  • resolution was changed from to fixed

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2009

Author Name: Anónimo (Anónimo)


Milestone Version 0.11.0 deleted

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Development

No branches or pull requests

1 participant