Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRASS Plugin: Map name input field not working correctly for modules that take multiple input maps #11549

Closed
qgib opened this issue Jan 16, 2009 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Jan 16, 2009

Author Name: benducke - (benducke -)
Original Redmine Issue: 1489

Redmine category:grass
Assignee: Lorenzo Masini


E.g.: open the "r.patch" module dialog. You will see the
"Type in map names .." field, which works just fine.
But the "[...]" browse button takes the user to a
"Save As" dialog, which is completely dysfunctional in
this context. What it should open is a widget that
allows users to select one or more maps in the current
GRASS mapset.

If that is too much work to go into QGIS 1.0.0, I'd
suggest getting rid of that button altogether. It
will be a little inconvenient for the user having
to manually type in map names, but still better
than popping up a misleading dialog.

@qgib
Copy link
Contributor Author

qgib commented Mar 24, 2009

Author Name: Markus Neteler (Markus Neteler)


I have tried:

svn diff src/plugins/grass/modules
Index: src/plugins/grass/modules/r.patch.qgm
===================================================================
--- src/plugins/grass/modules/r.patch.qgm       (revision 10412)
+++ src/plugins/grass/modules/r.patch.qgm       (working copy)
@@ -4,6 +4,6 @@
 <qgisgrassmodule label="Create new raster by combining other rasters" module="r.patch">
        <option key="input"/>
        <flag key="z" answer="off" hidden="no" />
-       <file key="input" label="Type in map names separated by a comma" />
+       <option key="input" label="Alternatively, type in map names separated by comma" />
        <option key="output" />
 </qgisgrassmodule>

but this leads to a selector (no more free text field). Maybe there is something else than "file" or "option" which creates a free text field without the button behind it?

Markus

@qgib
Copy link
Contributor Author

qgib commented Jun 17, 2009

Author Name: Lorenzo Masini (Lorenzo Masini)


Fixed in 26fba47 (SVN r10946).
See the r.path.qgm module to use the new feature into the other modules that require it.


  • resolution was changed from to fixed
  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Aug 11, 2009

Author Name: Paolo Cavallini (@pcav)


  • status_id was changed from Closed to Feedback
  • resolution was changed from fixed to

@qgib
Copy link
Contributor Author

qgib commented Aug 11, 2009

Author Name: Paolo Cavallini (@pcav)


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Aug 11, 2009

Author Name: Paolo Cavallini (@pcav)


  • resolution was changed from to fixed
  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS labels May 24, 2019
@qgib qgib added this to the Version 1.0.3 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS
Projects
None yet
Development

No branches or pull requests

1 participant