Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to have a single window icon on Microsoft Windows #12333

Closed
qgib opened this issue Dec 12, 2009 · 1 comment
Closed

patch to have a single window icon on Microsoft Windows #12333

qgib opened this issue Dec 12, 2009 · 1 comment
Labels
Build/Install Related to compiling or installing QGIS Feature Request
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Dec 12, 2009

Author Name: Steven Mizuno (Steven Mizuno)
Original Redmine Issue: 2273

Redmine category:build/install
Assignee: nobody -


On Windows builds of QGIS I have noticed that there are two slightly different window icons in various windows. This is not the case for Linux builds.

I found that a main window icon is set in [[QgisApp]]. For Microsoft Windows there is an icon placed in a resource file, which becomes the application icon. The main window icon is displayed on the QGIS main window and for any window it owns. The application icon (from the resource) is used for all windows not owned by the main window.

It is better if an application icon is set on the QApplication object so all windows inherit this icon unless a different icon is set for a window.

This patch removes the window icon set in [[QgisApp]]. For Linux/Mac it sets the application icon in the constructor of [[QgsApplication]]. For Windows, the icon in the resource is the application icon (no icon is set in [[QgsApplication]]).


@qgib
Copy link
Contributor Author

qgib commented Dec 12, 2009

Author Name: Jürgen Fischer (@jef-n)


applied in b4aaa2f (SVN r12425). Thanks.


  • resolution was changed from to fixed
  • status_id was changed from Open to Closed

@qgib qgib added Feature Request Build/Install Related to compiling or installing QGIS labels May 24, 2019
@qgib qgib added this to the Version 1.4.0 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build/Install Related to compiling or installing QGIS Feature Request
Projects
None yet
Development

No branches or pull requests

1 participant