-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial Query Plugin source for evaluation #12694
Comments
Author Name: Tim Sutton (Tim Sutton) Looks like some include paths are not configured in the cmakelists.txt:
|
Author Name: Tim Sutton (Tim Sutton) Adding spatialindex dir fixed it:
Having built and tested the plugin (works great!) my feedback is this: a) I think we should put it in the main gui rather than as a plugin.
Regardless of whether it is added as a plugin or in gui if they above issues are resolved it would be +1 from me for inclusion into 1.5 - nice work! Tim |
Author Name: Luiz Motta (@lmotta) This is the source code of an Spatial Query Plugin, I would like you guys to verify the code, and if it's in good shape, include it in the next version ( 1.5 ) of QGIS. Please verify the file CMakeLists.txt to fix the include paths of the GEOS libray. |
Author Name: Luiz Motta (@lmotta) Update zipfile with source of Spatial Query with feedback by Tim |
Author Name: Tim Sutton (Tim Sutton) Hi Much better. Just the ok / Cancel QButtonBox needs to come down to the bottom of the dialog to follow the 'principle of least surprise'. Regards Tim |
Author Name: Luiz Motta (@lmotta) Upload plugin with last suggestion |
Author Name: Tim Sutton (Tim Sutton) I have committed this patch as of 349b1ec (SVN r13357). Parabens e obrigado! Note there is still one more thing that should be sorted out - the Qt includes should be done in the form
and not
Note also that I have made some changes to the behaviour and layout of the dialog to try to improve usability - hope they are all to your liking. Regards Tim
|
Author Name: Luiz Motta (@lmotta) Thanks Tim. |
Author Name: Giovanni Manghi (@gioman) Hi Luiz, just tested the plugin, looks great! two notes: *) if you resize the plugin windows then also two dropdowns resize, see attached image *) when you click the button "close" (after having run a query) the plugin closes. I would like to see also a button "back" (or else) to let the user return to the plugin main window, so he can run another query without having to open again the plugin obrigado! |
Author Name: Jürgen Fischer (@jef-n) the resizing issue doesn't happen in current trunk. |
Author Name: Luiz Motta (@lmotta) About: When you click the button "close" (after having run a query) the plugin closes. I would like to see also a button "back" (or else) to let the user return to the plugin main window, so he can run another query without having to open again the plugin. To answer your suggestion I made the following changes:
2)qgsspatialquerydialog.cpp
} // void [[QgsSpatialQueryDialog]]::on_buttonBox_rejected() 2.2) Change method - runQuery } // void [[QgsSpatialQueryDialog]]::runQuery() |
Author Name: Jürgen Fischer (@jef-n)
|
Author Name: Luiz Motta (@lmotta) The patch (spatialquery_update.zip) content only the files changed and the one new file (don´t has all source). The spatialquery work with valid features, then, if have invalid features, the user can believe the invalid features don´t have topologic relation. This update will show the the report about invalid features in both layers. Please, verify this work.
|
Author Name: Luiz Motta (@lmotta) The attachment, spatialquery_update_example.JPG, illustrates the update. |
Author Name: Tim Sutton (Tim Sutton)
|
Author Name: Tim Sutton (Tim Sutton)
|
Author Name: Tim Sutton (Tim Sutton) Hi I tested the patch. There are a few minor issues that should be fixed before we commit it:
If you can address these issues we can apply your changes. On a side note it would be good to consider creating a patch to move this functionality into the core of QGIS and displayed in the vector menu, and also to coordinate with Carson about the possible overlaps in functionality between this plugin and the Vector->Geometry Tools so that there is no duplication in QGIS of these tools (unless there is a compelling reason to keep both). Muito obrigado! Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, The changes are in spatialquery_update_II.zip (only files with changes). You can see the new layout in the picture spatialquery_II.jpg. I fixed the bug of frozen when unchecked the show log messages Please, see can apply the changes. The merge of spatial query in vector menu (work of Carson), i believe better when migrate the vector functionalities from Pyhon to C++ Regards, |
Author Name: Tim Sutton (Tim Sutton) Thanks for making those tweaks. I have applied your patch as b5bad19 (SVN r15138). Best regards Tim
|
Author Name: Luiz Motta (@lmotta) Tim, The last changes are in spatialquery_update_III.zip (only files with changes). You can see the new layout in the picture spatialquery_III.jpg. At now, the dialog box is more compact. Please, see can apply the changes. Regards, |
Author Name: Luiz Motta (@lmotta) Tim, I forgot to reopen this ticket for you receive the message above by trac. Sorry, again, do you can see the changes. Regards,
|
Author Name: Luiz Motta (@lmotta) Tim, The update IV (see spatialquery_update_IV.jpg) have the features:
Content of spatialquery_update_IV.zip:
The 'selectall.png' can be deleted Please, see can apply the changes. Regards, Luiz |
Author Name: Luiz Motta (@lmotta) Tim, The update V (see spatialquery_update_V.jpg) have the features: 1)Fixed BUG: Use operator DISJOINT. 2)New functionality:Set subset in target layer with selected features(GUI is new button). 3)Better status(enable or disable) for buttons add and remove FIDs of query, when user make new selection on target. Content of spatialquery_update_IV.zip:
qgsspatialquery.cpp, 2)GUI all files: qgsspatialquerydialogbase.qrc, *Can delete the "selectall.png" in the trunk Please, see can apply the changes. Regards, Luiz |
Author Name: Tim Sutton (Tim Sutton) Hi Luiz I tried to build version V but get:
Also please note:
Thanks! Tim |
Author Name: Luiz Motta (@lmotta) Tim, Thanks for your orientation and sorry by compile error. You can compile with new update of "qgsspatialquerydialog.cpp" I will read again about HIG and change the GUI of Plugin. Regards, Luiz |
Author Name: Luiz Motta (@lmotta) Tim, The update VI(update_spatiaquery_VI.zip) have: qgsspatialquerydialog.cpp, qgsspatialquerydialog.h and qgsspatialquerydialogbase.ui I made changes for stay on standard GUI of QGIS. I will contact Robert Szczepaneks for make better icons. Please, test the update VI. Regards, Luiz |
Author Name: Tim Sutton (Tim Sutton) Hi Sorry I found some more issues:
Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, I changed the color of FID selected, at now, this color is the same of identify tool. The selection of FID is only a manner to view the geometry, this is not select the feature in layer. The status showing the number of selected features in target layer. The idea of list of FID's is show the features from query. when selected this item identfy the geometry. You can see the new GUI in update_spatialquery_VII.png. The update files (update_spatialquery_VII.zip) are: qgsrubberselectid.cpp, The icons will be changed with help Robert Szczepaneks. Regards, Luiz |
Author Name: Tim Sutton (Tim Sutton) Hi Zoom to identify still does not work for me - it zooms to somewhere completely off the map The middle button (add selection) - I cant see to get it enabled in any circumstance - what is the trick here On the initial screen, I think it needs to be made clearer for new users which layer will actually have features selected. It will fee more natural if initial ui works like this:
I think it would also be nice to have a checkbox 'Add results to selection' which is enabled by default - the most common use case in my mind is that the user will want to use this tool to select a bunch of features so it makes sense to make this the default behaviour. Many thanks for the improvements you are making to the useful tool! Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, The Zoom in feature item is verify:
I made several change in GUI, please, see the picture (spatialquery_update_VIII.jpg). Theses are:
For create new layer by subset have these limits:
Can erase the old images files, at now, only three images are used: spatialquery.png, selectcreatelayer.png and itemscreatelayer.png |
Author Name: Luiz Motta (@lmotta) Tim, I update the file "qgsspatialquerydialog.cpp" for fix bug for "Remove from selection", the old not add correct the item in list for "Use result for" |
Author Name: Luiz Motta (@lmotta) Tim, The spatialquery_IX.zip, update files qgsspatialquerydialog.h and qgsspatialquerydialog.cpp. The choices for combobox "Use result for" is better when dont have selection in target layer. Show the choice of "Use result for" in the number of selected features. For evaluation, first update VIII (have more files update) then update IX |
Author Name: Tim Sutton (Tim Sutton) Hi I get a bunch of errors compiling your latest:
I'm using Qt 4.6 on ubuntu. By the way it will be easier for me if you just supply your updates as a patch, or a zip of the whole plugin dir as I test on different computers and the current way of you supplying updates means I need to run through each zip file to make sure I didnt leave anything out. Once the above problem is resolved, I will probably go ahead and commit your updates to trunk. Thanks for all the great work! Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, The full path for Spatialquery X (all files) was attached. I fixed the error compile for Qt 4.6. Regards, |
Author Name: Tim Sutton (Tim Sutton) Hi Luiz I made a few small tweaks to some of the labels to make it more 'human'. I had three remaining small issues:
I have committed your work to date as I think it already provides a substantial improvement over existing functionality. See d0e4d4b (SVN r15301), 0b65851 (SVN r15302), 9950959 (SVN r15303). Muito obrigado! Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, I update (spatialquery_XI_update.zip) files: qgsspatialquerydialog.h and cpp qgsspatialquery.cpp qgsspatialqueryplugin.cpp The original source have BUG when run with layers open in QGIS, where, have only one layer vector and others layers are diferent types. I made change label of "Disjoint" to "Is disjoint". I need yours data to understand why 'zoom to' not work. Please share for me yours data. Regards, Luiz |
Author Name: Tim Sutton (Tim Sutton) Hi Your changes were committed in a894e32 (SVN r15485) thanks. Will try to get the sample data to test with to you tomorrow. Regards Tim |
Author Name: Luiz Motta (@lmotta) Tim, I received the new icons made by Robert Szczepanek. Please update icons from spatialquery_new-icons.zip. Thanks Robert Szczepanek Luiz |
Author Name: Tim Sutton (Tim Sutton) Applied in 1aa1d5c (SVN r15492) - thanks! I think I will close this ticket now ok? Muito obrigado por o boa trbalho que voce faiz! Ok my Portuguese still sucks :-) Regards Tim
|
Author Name: Luiz Motta (@lmotta) Tim, You can remove these PNG files in trunk: select.png selectadd.png selectall.png selectesubsetlayer.png selectremove.png You can close this ticket now. Regards, Luiz |
Author Name: Luiz Motta (@lmotta)
Original Redmine Issue: 2634
Redmine category:c++_plugins
Assignee: Tim Sutton
It is the source code of Spatial Query Plugin.
I would like you can be assess this plugin to be placed in version 1.5 of QGIS.
Please verify the file CMakeLists.txt to use dependece GEOS libray.
The text was updated successfully, but these errors were encountered: