Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis doesn't show any message/warning when splitting a polygon with an invalid geometry #12889

Closed
qgib opened this issue Jun 21, 2010 · 9 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Jun 21, 2010

Author Name: xr6ute - (xr6ute -)
Original Redmine Issue: 2829

Redmine category:digitising
Assignee: nobody -


While editing a shape file, trying to split the feature has no affect. Trying to split the same shape file with v1.2.0 used to cause a crash.
Creating a new ring and splitting that does work as expected.


@qgib
Copy link
Contributor Author

qgib commented Jun 21, 2010

Author Name: Paolo Cavallini (@pcav)


Confirmed. In my case, it crashes with:

Error:

GDAL Error 1: [[TopologyException]]: found non-noded intersection between LINESTRING (138.783 -34.5531, 138.783 -34.5531) and LINESTRING (138.783 -34.5531, 138.783 -34.5531) at 138.783 -34.5531

Segmentation fault

@qgib
Copy link
Contributor Author

qgib commented Jun 21, 2010

Author Name: Giovanni Manghi (@gioman)


see attached image. The geometry does not seems correct. Fix it and the tool will work fine.

@qgib
Copy link
Contributor Author

qgib commented Jun 21, 2010

Author Name: Jürgen Fischer (@jef-n)


Replying to [comment:2 pcav]:

Confirmed. In my case, it crashes with:

No crash here.

Error:

GDAL Error 1: [[TopologyException]]: found non-noded intersection between LINESTRING (138.783 -34.5531, 138.783 -34.5531) and LINESTRING (138.783 -34.5531, 138.783 -34.5531) at 138.783 -34.5531

GDAL? Strange. There should be a GEOS exception, if any. Although the rest of the message looks like one. Doesn't this only crash with some plugins involved?

@qgib
Copy link
Contributor Author

qgib commented Jun 21, 2010

Author Name: Paolo Cavallini (@pcav)


So we got another problem now: I suspected the layer was invalid, so I checked with fTools, which it couldn't find the error.
Two issues then:

  • QGIS shouldn't crash in case of editing invalid geometries, and it should report a meaningful error when trying to manipulate them

  • incorrect geometries should be found by fTools (probably better opening a ticket on this)

@qgib
Copy link
Contributor Author

qgib commented Jun 22, 2010

Author Name: Paolo Cavallini (@pcav)


Right: uninstalling SDA4PP plugin removes the crash. A meaningful erro message would be good to have anyway.

@qgib
Copy link
Contributor Author

qgib commented Jun 22, 2010

Author Name: xr6ute - (xr6ute -)


Sorry about the bad geometry file I hadn't noticed that, and I can confirm Lutra is correct, once I fixed the geometry the tool worked as expected.
Thanks for looking in to this, the response is exceptional, inline with the overall QGIS experience :-).

@qgib
Copy link
Contributor Author

qgib commented Jun 23, 2010

Author Name: Giovanni Manghi (@gioman)


New description:

See attached polygon shapefile. It has an invalid geometry and if you try to split it qgis does nothing. It should throw a message/warning.

@qgib
Copy link
Contributor Author

qgib commented Apr 22, 2011

Author Name: Jürgen Fischer (@jef-n)


fixed in f33d9f2 (SVN r15813).

@qgib
Copy link
Contributor Author

qgib commented Apr 22, 2011

Author Name: Jürgen Fischer (@jef-n)


  • resolution was configured as fixed
  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels May 24, 2019
@qgib qgib added this to the Version 1.7.0 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Development

No branches or pull requests

1 participant