Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase/decrease priority in rule-based rendering #14407

Closed
qgib opened this issue Nov 1, 2011 · 9 comments
Closed

Increase/decrease priority in rule-based rendering #14407

qgib opened this issue Nov 1, 2011 · 9 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Nov 1, 2011

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 4480
Affected QGIS version: master
Redmine category:symbology


The buttons Increase/decrease priority in rule-based rendering do not work


@qgib
Copy link
Contributor Author

qgib commented Dec 16, 2011

Author Name: Giovanni Manghi (@gioman)


  • fixed_version_id was configured as Version 1.7.4

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2011

Author Name: Richard Duivenvoorde (@rduivenvoorde)


hi Paolo,

I'm actually busy with this, because using it it appeared that the decreasing and increasing buttons were workinge (in my view), but the selection disappeared every time from the selected item.
Besides that it was possible to select multiple items while all buttons only work when just one item is selected.

I have finished that (will do pull request today), but if you give scenario (and data?) for how it is NOT working for you, I can maybe also have a look into that.


  • version was configured as master
  • crashes_corrupts_data was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2011

Author Name: Paolo Cavallini (@pcav)


Load a vector, create two rules, select one, press decrease/increase priority buttons: no effect.
Thanks.

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2011

Author Name: Richard Duivenvoorde (@rduivenvoorde)


It is working for me.

See attached project+data+style.

If you load that project you have a layer with some points and three rules.

first make sure you UNcheck 'Use only first matched rule' then:

-1- You will see green and red dots (NO blue).
Blue has prio 1 meaning all dots will be painted blue FIRST, but then the two other rules paint it red/green

-2- If you decrease prio of (no filter) to 3 (in your qgis clicking on rule, click decrease, click on rule again, decrease; in mine (fixed) I just click decrease twice).
Now you will see that dots are all bleu: because FIRST red green rules apply (have higher prio), then the last prio rule will apply, making them blue.

-3- if you now CHECK 'Use only first matched rule' and Apply, you will see the red green dots again.
Because red and green have prio 1 and 2 and (no filter)/bleu has prio 3, only prio 1 and 2 will apply, and 3 is not applied anymore.

My conclusion: it just works :-)

If you do not agree, please show me a scenario which fails in your opinion (a little more clear then the one in comment #3 ;-) )

Otherwise, this bug can be closed


  • 4145 was configured as test.zip

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2011

Author Name: Paolo Cavallini (@pcav)


Agreed, it works. Two minor confusing things though:

  • the direction of the arrow is opposite to the actual displacement of the item
  • once moved, focus on the item is lost

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2011

Author Name: Richard Duivenvoorde (@rduivenvoorde)


I think I fixed all this in #79

focus stays on selected item now

sort on priority once you used the 'increase/decrease priority' button (I did not want to make it the default sorting because priority is not always the main target for a user)

Please test after pull 79 is honoured, and close this ticket if working

@qgib
Copy link
Contributor Author

qgib commented Apr 16, 2012

Author Name: Paolo Cavallini (@pcav)


  • fixed_version_id was changed from Version 1.7.4 to Version 1.8.0

@qgib
Copy link
Contributor Author

qgib commented May 12, 2012

Author Name: Alexander Bruy (@alexbruy)


Should be fixed by Martin's improvements for rule-based renderer


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented May 14, 2012

Author Name: Paolo Cavallini (@pcav)


  • status_id was changed from Feedback to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers labels May 24, 2019
@qgib qgib added this to the Version 1.8.0 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

No branches or pull requests

1 participant