Rule based symbology refine assistant forgets quotation marks for fields with special characters

[qgib]

Author Name: Regis Haubourg (@haubourg)
Original Redmine Issue: 5536
Affected QGIS version: 1.7.4
Redmine category:symbology

---

Tested with Qgis 1.7.4 standalone and qgis 1.8.0.4 from osgeow.

When trying to refine rules in rule based labeling interface, if field names contain spaces or non ascii characters, automatically generated rules queries do not include quotation mark for the field. See pictures attached and sample shapefile.
Ex: I get Montant re > '1000' instead of "Montant re" > 1000.
Map rendering is false but is rendered without any error message.

When testing each expression within the definition Query, error message raises "Filter expression parsing error:
syntax error, unexpected COLUMN_REF, expecting $end" . Putting quotation mark by hands gives a correct behaviour. Generating rules by hand, without using "refine" button does generate quotation marks.

• Possible other feature request : Newcoming users don't know that special characters is a bad pratice for fields names. Maybe a automatical clean in ogr export could be a good thing for shapefile at least.

• remark (not a bug): Another strange behaviour is that numerical values in range refining are quoted myfield > '1000' instead of Montant re > 1000. Could this affect performance since a type cast is necessary?

Cheers
régis

---

• rule_query_quotation_mark_missing.jpeg (Regis Haubourg)
• rule_query_quotation_mark_back.jpeg (Regis Haubourg)
• industrie.zip (Regis Haubourg)

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• category_id was changed from Map Legend to Symbology
• subject was changed from Rule based Labeling refine assistant forgets quotation marks for fields with special characters to Rule based symbology refine assistant forgets quotation marks for fields with special characters

[qgib]

Author Name: Hugo Mercier (@mhugo)

---

Fixed (pull request: #156).

Double quotes are now added to field names. Field names are also escaped and can contain accents (tested with some french accents), spaces, as well as quotes and double quotes.

[qgib]

Author Name: Martin Dobias (@wonder-sk)

---

fixed in bf86521

---

• resolution was changed from to fixed
• status_id was changed from Open to Closed