Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Scale List #15146

Closed
qgib opened this issue May 9, 2012 · 6 comments
Closed

Project Scale List #15146

qgib opened this issue May 9, 2012 · 6 comments

Comments

@qgib
Copy link
Contributor

qgib commented May 9, 2012

Author Name: Michael Douchin (@mdouchin)
Original Redmine Issue: 5561

Redmine category:project_loading/saving
Assignee: Alexander Bruy


This patch adds a new feature in Qgis Desktop project properties. The aim is to provide a way to configure and use a scale list for each project:

  • display and manage a list of user defined scales per project in the project properties dialog
  • replace the content of the status bar scale combobox if project scales are defined when opening an existing project
  • default scale list is used whenever no project scale list has been found

The patch can be found here
https://gist.github.com/2627175

PS: This is my first patch for Qgis, so feel free to comment/modify/annotate.
PS2: I assigned this patch to Alexander Bruy, author of the QScaleCombobox class.


@qgib
Copy link
Contributor Author

qgib commented May 9, 2012

Author Name: Nathan Woodrow (@NathanW2)


Good job. Looks good to me. Might have to wait until 1.8 is out though as it's a new feature, not really a bug fix.

@qgib
Copy link
Contributor Author

qgib commented May 9, 2012

Author Name: Alexander Bruy (@alexbruy)


Thanks for patch, I'll look at it ASAP. But as this new feature it can be applied only after releasing 1.8.0


  • fixed_version_id was changed from Version 1.8.0 to Version 2.0.0

@qgib
Copy link
Contributor Author

qgib commented May 9, 2012

Author Name: Michael Douchin (@mdouchin)


Thanks for reviewing this patch. Good point for postpone it to Qgis after 1.8.
Please have a look to my use of the method "showScale" and "mMapCanvas->updateScale()". I did not know very well Qgis core, so it may be a bit hacky...


  • pull_request_patch_supplied was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Jun 1, 2012

Author Name: Michael Douchin (@mdouchin)


"physical" file attached (just in case)


  • 4536 was configured as gistfile1.diff

@qgib
Copy link
Contributor Author

qgib commented Jul 5, 2012

Author Name: Alexander Bruy (@alexbruy)


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Jul 17, 2012

Author Name: Alexander Bruy (@alexbruy)


Available starting from fe2252d


  • resolution was changed from to fixed
  • status_id was changed from In Progress to Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant