Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit session only enabled for last selected layer #16038

Closed
qgib opened this issue Dec 27, 2012 · 4 comments
Closed

Edit session only enabled for last selected layer #16038

qgib opened this issue Dec 27, 2012 · 4 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering

Comments

@qgib
Copy link
Contributor

qgib commented Dec 27, 2012

Author Name: Nathan Woodrow (@NathanW2)
Original Redmine Issue: 6920
Affected QGIS version: master
Redmine category:map_legend


If a set of layers are highlighted in the layer list pressing the editing button only enables the last layer selected for editing.

It would be nice to have this ability to quickly enable a set of layers for editing rather then going through one by one.

@qgib
Copy link
Contributor Author

qgib commented Dec 27, 2012

Author Name: Larry Shaffer (Larry Shaffer)


Hi Nathan,

Is this a bug or feature request? Gonna assume the latter, since I've never seen the functionality before (unless I'm missing something).

I can add this pretty quickly as a single extra command in the contextual menu, when there are changeable vector layers within the selection. I see it showing up right below the Toggle Editing action, maybe as Toggle Editing for Selected.

Running the action might loop through the changeable vector layers and apply the same function as Toggle Editing, but not toggling off (skipping) any layer that has unsaved edits, resulting in a notification dialog that says something like:

"Some layers have unsaved edits and were not toggled off."

Then, list the layers. I have a similar listing integrated with project close dialog (working on it now), as per your suggestion.

Alternatively, Toggle Editing for Selected could have a submenu with On, Off (and maybe Toggle?) actions to allow the user to specifically control the functionality.

The only issue I know of is that @QgisApp::toggleEditing(QgsMapLayer*)@ is a private slot, so either a special signal or a QMetaObject needs set up to fire it for not-active-layer layers. Not sure why it can not just be a public slot, or have a wrapper public member. (Ran into this just yesterday, trying to fix another issue.)

@qgib
Copy link
Contributor Author

qgib commented Jun 28, 2014

Author Name: Jürgen Fischer (@jef-n)


  • fixed_version_id was changed from Version 2.0.0 to Future Release - Lower Priority

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0
  • regression was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Mar 9, 2019

Author Name: Giovanni Manghi (@gioman)


End of life notice: QGIS 2.18 LTR
*
Source:*
http://blog.qgis.org/2019/03/09/end-of-life-notice-qgis-2-18-ltr/


  • resolution was changed from to end of life
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Mar 9, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering labels May 24, 2019
@qgib qgib added this to the Future Release - Lower Priority milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Projects
None yet
Development

No branches or pull requests

1 participant