Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on WFS auth fail #16785

Closed
qgib opened this issue May 26, 2013 · 4 comments
Closed

Crash on WFS auth fail #16785

qgib opened this issue May 26, 2013 · 4 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Data Provider Related to specific vector, raster or mesh data providers

Comments

@qgib
Copy link
Contributor

qgib commented May 26, 2013

Author Name: Chris Berkhout (Chris Berkhout)
Original Redmine Issue: 7913
Affected QGIS version: master
Redmine category:web_services_clients/wfs


QGIS version: edge (commit d68524bfd774b6b2fd91f49d914bf18e3ae7c22f). Tried this in 1.8.0 and it didn't crash.

Adding a WFS layer, where authentication is required and unsuccessful (403), an error dialog is shown with "Host requires authentication" (screenshot: https://www.evernote.com/shard/s282/sh/f9016e96-b0f3-4a91-b516-15bf64af63a5/956d1f55071e9bc48f2bbfb7e7b098fa) and after clicking "OK", QGIS crashes.

OSX crash log: https://gist.github.com/chrisberkhout/011728d91868e19e012a

Priority=Blocker since it's "a regression from a previous QGIS version".


@qgib
Copy link
Contributor Author

qgib commented May 29, 2013

Author Name: Laurent Defert (Laurent Defert)


The patch in attachement fixes this issue for me.


  • 5802 was configured as 0001-Fix-crash-when-authentication-fails.-Fix-7913.patch

@qgib
Copy link
Contributor Author

qgib commented May 29, 2013

Author Name: Giovanni Manghi (@gioman)


Laurent Defert wrote:

The patch in attachement fixes this issue for me.

Hi! thanks for the patch! Would you be available to make a GitHub pull request? Otherwise patches here on the track can be "lost" for a while. On Github the pull request will be received by all core developers that then can review it and commit it.
Cheer!


  • pull_request_patch_supplied was changed from 0 to 1
  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented May 30, 2013

Author Name: Laurent Defert (Laurent Defert)


Done. Thanks.

@qgib
Copy link
Contributor Author

qgib commented May 31, 2013

Author Name: Marco Hugentobler (@mhugent)


Fixed in changeset "ce925496c03009056978a8b343e4c7a5237973d5".


  • status_id was changed from Feedback to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Crash/Data Corruption labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

No branches or pull requests

1 participant