QgsVectorLayerEditBuffer.addedFeatures() function binding on Windows 8 causes crash

[qgib]

Author Name: Larry Shaffer (Larry Shaffer)
Original Redmine Issue: 8543
Affected QGIS version: master
Redmine category:python_plugins

---

Repeatable steps:

1. Put a vector layer into edit mode
2. Add a feature
3. Run commands in console

eb = iface.activeLayer().editBuffer()
eb.addedFeatures()

1. Crash

QgsVectorLayerEditBuffer.addedFeatures() works fine on Mac (10.7.5, latest master), returning a dict.

Will try to get, or inspect, a crash dump soon.

[qgib]

Author Name: Salvatore Larosa (@slarosa)

---

Hi Larry,
this should not be hard to solve, I haven't a build environment under windows.

Anyone could try the following patch:

diff --git a/python/core/qgsvectorlayereditbuffer.sip b/python/core/qgsvectorlayereditbuffer.sip
index 0b6af3a..11ff4ab 100644
--- a/python/core/qgsvectorlayereditbuffer.sip
+++ b/python/core/qgsvectorlayereditbuffer.sip
@@ -102,7 +102,7 @@ class QgsVectorLayerEditBuffer : QObject
       \
ote added in v1.6 */
     void committedAttributesDeleted( const QString& layerId, const QgsAttributeList& deletedAttributes );
     void committedAttributesAdded( const QString& layerId, const QList<QgsField>& addedAttributes );
-    void committedFeaturesAdded( const QString& layerId, const QgsFeatureList& addedFeatures );
+    void committedFeaturesAdded( const QString& layerId, const QgsFeatureMap& addedFeatures );
     void committedFeaturesRemoved( const QString& layerId, const QgsFeatureIds& deletedFeatureIds );
     void committedAttributeValuesChanges( const QString& layerId, const QgsChangedAttributesMap& changedAttributesValues );
     void committedGeometriesChanges( const QString& layerId, const QgsGeometryMap& changedGeometries );

[qgib]

Author Name: Larry Shaffer (Larry Shaffer)

---

Hi Salvatore,

Not sure how that signal relates to the @QgsVectorLayerEditBuffer.addedFeatures()@ public function.

Also, wouldn't changing that in the .sip file probably cause a build error when sip doesn't find a matching signature in the header file (qgsvectorlayereditbuffer.h)?

[qgib]

Author Name: Salvatore Larosa (@slarosa)

---

sorry for the overzealous approach, forget my note!

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

works fine for me (on windows 10 x86 and x86_64)

---

• crashes_corrupts_data was changed from 0 to 1
• resolution was changed from to worksforme
• status_id was changed from Open to Closed