Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLD : an invalid sld is generated when exporting a polygon with fill styles #17313

Closed
qgib opened this issue Sep 3, 2013 · 3 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers

Comments

@qgib
Copy link
Contributor

qgib commented Sep 3, 2013

Author Name: Yewondwossen Assefa (Yewondwossen Assefa)
Original Redmine Issue: 8567
Affected QGIS version: master
Redmine category:symbology


This was initially reported on the mailing list:

The sld produced is invalid at the GraphicFill level:

se:GraphicFill
se:Graphic/
se:Mark
se:WellKnownNamex</se:WellKnownName>
se:Stroke
<se:SvgParameter name="stroke">#0000ff</se:SvgParameter>
</se:Stroke>
</se:Mark>
</se:GraphicFill>

The Mark element sould be a child of the se:Graphic element and not se:GraphicFill:
se:GraphicFill
se:Graphic
se:Mark
se:WellKnownNamex</se:WellKnownName>
se:Stroke
<se:SvgParameter name="stroke">#0000ff</se:SvgParameter>
</se:Stroke>
</se:Mark>
</se:Graphic>
</se:GraphicFill>

The error comes from file ./src/core/symbology-ng/qgssymbollayerv2utils.cpp QgsSymbolLayerV2Utils::fillToSld (around line 1523).
Attached is the diff to correct it. This has been tested locally and gives the expected result.


@qgib
Copy link
Contributor Author

qgib commented Sep 3, 2013

Author Name: Giovanni Manghi (@gioman)


Hi, thanks for the patch. Would you mind make a pull request on github? here patches are likely to be overlooked.


  • operating_system was changed from all to
  • status_id was changed from Open to Feedback
  • category_id was configured as Symbology

@qgib
Copy link
Contributor Author

qgib commented Sep 3, 2013

Author Name: Giuseppe Sucameli (@brushtyler)


Fixed in changeset "4bc1beb844cef09b5b58570a4e402a5c422bc32c".


  • status_id was changed from Feedback to Closed

@qgib
Copy link
Contributor Author

qgib commented Sep 3, 2013

Author Name: Giuseppe Sucameli (@brushtyler)


The patch is applied, thanks!
Please, the next time create a pull request on GitHub.


  • resolution was changed from to fixed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

No branches or pull requests

1 participant