Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map overview extend broken under qgis master (2.3) #18215

Closed
qgib opened this issue Feb 24, 2014 · 5 comments
Closed

map overview extend broken under qgis master (2.3) #18215

qgib opened this issue Feb 24, 2014 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Feb 24, 2014

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 9643
Affected QGIS version: master

Assignee: Martin Dobias


Under qgis master (2.3), the map overview extend regressed:

  • Under qgis 2.2, the map overview extend is confined to only the layers that have activated the '[x] show in overview' option. (see overview-extend-qgis2.2-ok.png)
  • Under qgis master (2.3), the map overview extend extends to cover all layers, even the ones that do not show in overview. (see overview-extend-qgis2.3-broken.png)

I've attached a test project which demonstrates this quite well. Flagging this as a multi-thread rendering issue.


@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2014

Author Name: Martin Dobias (@wonder-sk)


Hmm... actually the current behavior seems like the correct one to me :-) and previous seems wrong.

Like this you can always see where is your map canvas view is within the project extent - even if no layers have been explicitly added to the overview.

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2014

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)


Martin, QGIS' original behavior was to simply show project extend, but it was changed in late 2012 to show only extend of visible layers in overview, see this commmit: #12673cf6ad5ec0afcb033e59e60af89384e234f99#diff-517f2b5299b4c3032c5d22025594f0e5

In my uses of the overview map, I find the 2012 change a great improvement. A project extend can very often go beyond the extend of interest. For e.g., I often produce national maps with a background layer that shows regional political boundaries as well as sea boundaries. That background layer extends way beyond the area of interest and is there to add partial neighbor context when exporting maps.

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2014

Author Name: Martin Dobias (@wonder-sk)


Fixed in changeset "29e9272285e1196602d535476b7fd58e2b3f0f13".


  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2014

Author Name: Martin Dobias (@wonder-sk)


Updated so that overview uses extent of layers visible in overview. If no layers are visible in overview, it would use full extent. win-win :-)

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2014

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)


Excellent.

@qgib qgib added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label May 24, 2019
@qgib qgib added this to the Version 2.4 milestone May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

No branches or pull requests

1 participant