Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creation of recursive models (or provide solution to break out of loops) #18423

Open
qgib opened this issue Mar 27, 2014 · 9 comments
Open
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Mar 27, 2014

Author Name: Anita Graser (@anitagraser)
Original Redmine Issue: 9909
Affected QGIS version: 2.4.0
Redmine category:processing/modeller
Assignee: Victor Olaya


Currently, it is possible to include the model itself into the model workflow thus creating a model which calls itself. Of course this causes errors.

@qgib
Copy link
Contributor Author

qgib commented Mar 27, 2014

Author Name: Victor Olaya (@volaya)


mmm, actually it shouldn't cause error. The modeler is designed to allow nested models. So it's a bug, but the solution is not removing models in the list of algorithms in the model, but fixing it.

@qgib
Copy link
Contributor Author

qgib commented Mar 28, 2014

Author Name: Anita Graser (@anitagraser)


Sorry for being unclear :-)

It's great that modeler allows nested models! I just wanted to suggest that it might make sense to check if the user is creating circular references in his models. If model A calls model A to get to its results, it won't ever stop, or is there a way to break out of such loops?

@qgib
Copy link
Contributor Author

qgib commented Mar 28, 2014

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from It's possible to create recursive models to It's possible to stop recursive models?

@qgib
Copy link
Contributor Author

qgib commented Mar 28, 2014

Author Name: Anita Graser (@anitagraser)


  • subject was changed from It's possible to stop recursive models? to Prevent creation of recursive models (or provide solution to break out of loops)

@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2014

Author Name: Giovanni Manghi (@gioman)


  • category_id removed 64
  • crashes_corrupts_data was configured as 0
  • version was configured as 2.4.0
  • project_id was changed from 78 to 17

@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2014

Author Name: Giovanni Manghi (@gioman)


  • category_id was configured as Processing/Modeller

@qgib
Copy link
Contributor Author

qgib commented Jan 18, 2016

Author Name: Victor Olaya (@volaya)


fixed in #a549ded47bf6bfebc050d64502ac3dc8b9e921d6

@qgib
Copy link
Contributor Author

qgib commented Jan 18, 2016

Author Name: Victor Olaya (@volaya)


  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
@YoannQDQ
Copy link
Contributor

This still crashes QGIS (3.30)

@YoannQDQ YoannQDQ reopened this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

2 participants