Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on rollback after addition of a feature #18781

Closed
qgib opened this issue May 26, 2014 · 4 comments
Closed

Crash on rollback after addition of a feature #18781

qgib opened this issue May 26, 2014 · 4 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@qgib
Copy link
Contributor

qgib commented May 26, 2014

Author Name: Martin Dobias (@wonder-sk)
Original Redmine Issue: 10362
Affected QGIS version: master

Assignee: Matthias Kuhn


Something is getting wrong with the vector layer commands.

Steps to reproduce:

  1. add a vector layer
  2. start editing
  3. add a new feature
  4. stop editing without saving changes (rollback) -> crash

In qgsattributeform.cpp, I have tried to move beginEditCommand() on line 177 to the else branch few lines later. That helps, but then there is a new issue that new "add feature" command is immediately undo-ed (i.e. it is still in the undo stack, but not active).

@qgib
Copy link
Contributor Author

qgib commented May 26, 2014

Author Name: Giovanni Manghi (@gioman)


is a regression?

@qgib
Copy link
Contributor Author

qgib commented May 26, 2014

Author Name: Martin Dobias (@wonder-sk)


Yes, related to fix of #18758

@qgib
Copy link
Contributor Author

qgib commented May 26, 2014

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to Severe/Regression

@qgib
Copy link
Contributor Author

qgib commented May 27, 2014

Author Name: Matthias Kuhn (@m-kuhn)


Fixed in changeset "644dd13c3a00d55e89bf14a917e5dfd23dcd22bb".


  • status_id was changed from Open to Closed

@qgib qgib added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

No branches or pull requests

1 participant