DbManager allows users to input missing column names for row id and geometry

[qgib]

Author Name: Loïc BARTOLETTI (@lbartoletti)
Original Redmine Issue: 11037
Affected QGIS version: 2.4.0
Redmine category:db_manager

---

Atlas crash when using a spatialite VIEW in coverage layer (tested on Window 64 and FreeBSD).
Works fine with PostGis View.

---

• QGis_test_atlas.zip (Loïc BARTOLETTI)
• test_atlas_add_view.png (Loïc BARTOLETTI)
• QGis_test_atlas.zip (Loïc BARTOLETTI)

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

Do you have a spatialite data file which demonstrates this that I can test with?

---

• status_id was changed from Open to Feedback

[qgib]

Author Name: Loïc BARTOLETTI (@lbartoletti)

---

Here a project with spatialite data.

test_atlas is a layer
atlas is a view created like this:

CREATE VIEW "atlas" AS 
SELECT "ROWID", "info", ST_Union("geom") as "geom" 
FROM "test_atlas" 
GROUP BY "info"

and added with DB Manager (see PNG image)

---

• 7730 was configured as QGis_test_atlas.zip
• 7731 was configured as test_atlas_add_view.png

---

• QGis_test_atlas.zip (Loïc BARTOLETTI)
• test_atlas_add_view.png (Loïc BARTOLETTI)

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

I get an error trying to open that zip. Can you please re-upload?

[qgib]

Author Name: Loïc BARTOLETTI (@lbartoletti)

---

I forget to say that works when I create a table like this:

CREATE TABLE "union_atlas" AS
SELECT "ROWID" as "ROWID" , "info"  as "info", ST_Union("geom") AS "geom"
FROM "test_atlas"
GROUP BY "info";

---

• 7736 was configured as QGis_test_atlas.zip

---

• QGis_test_atlas.zip (Loïc BARTOLETTI) - New version

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

Ok - I've fixed the crash (because crashing is bad!), but the real problem is in your query/db manager. In your screenshot you have entered "ROWID" as the unique values column, but this column does not exist in your query. This causes the layer to load in a broken state -- some things work, but the behaviour is undefined (for instance, try opening the attribute table on this layer).

I'm reassigning this bug to db manager plugin as you should not be allowed to input an invalid column name as the unique column or geometry column.

---

• subject was changed from Composer/Atlas crash when using spatialite VIEW in coverage layer to DbManager allows users to input missing column names for row id and geometry
• category_id was changed from Map Composer/Printing to DB Manager
• status_id was changed from Feedback to In Progress

[qgib]

Author Name: Sandro Santilli (@strk)

---

does not cause crash or corruption anymore... is it really in progress ?

---

• crashes_corrupts_data was changed from 1 to 0

[qgib]

Author Name: Giuseppe Sucameli (@brushtyler)

---

Fixed in changeset "2a57b170685a45cb939457933b1474ac02d78ee5".

---

• status_id was changed from In Progress to Closed