Labeling Settings window's width expand beyond reason when a large expression is used

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 11061
Affected QGIS version: master
Redmine category:gui

---

The labeling settings window's width expands to the width of the monitor when a large expression is used as label. What I think happens is that the expression widget's text input tries to grow to display the expression string as much as it can. That's not a bad idea, but the end result is really bad for very long strings (which happens as soon as you add a few conditional statements in there). There should be a reasonable growth limit that prevents the window from filling the monitor's width.

See attached screenshot. Problem started in the late stage of QGIS 2.4 development, and currently affects master too.

Setting priority to high as it is very problematic on small monitors.

---

• too_wide.png (Mathieu Pellerin - nIRV)
• labels.png (Giovanni Manghi)
• bug.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Arnaud Morvan (@arnaud-morvan)

---

Tested on master with Ubuntu 14.04, works good, not expanding.

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Arnaud, screenshot please? :)

The label must be a long expression string.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

I tested also on Windows/master, it works as expected too.

---

• resolution was changed from to fixed/implemented
• status_id was changed from Open to Closed
• 7884 was configured as labels.png

---

• labels.png (Giovanni Manghi)

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Definitively not fixed. Steps to reproduce:

1. Create a project, add one vector layer (polygon, point, line, doesn't matter)
2. Open the Layer Properties window, and go in the label section
3. Activate the label checkbox and paste the following expression as label: CASE WHEN 1 = 1 THEN 'insert a label, make this expression long' ELSE 'insert a different label, not fixed' END
4. Close the Layer Properties window to apply the label
5. Re-open the Layer Properties window, see how its width as grown to unreasonable size. It can't be reduced in size either.

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Mathieu Pellerin - nIRV wrote:

Definitively not fixed. Steps to reproduce:

1. Create a project, add one vector layer (polygon, point, line, doesn't matter)
2. Open the Layer Properties window, and go in the label section
3. Activate the label checkbox and paste the following expression as label: CASE WHEN 1 = 1 THEN 'insert a label, make this expression long' ELSE 'insert a different label, not fixed' END
4. Close the Layer Properties window to apply the label
5. Re-open the Layer Properties window, see how its width as grown to unreasonable size. It can't be reduced in size either.

I tested again on latest qgis master (on Windows and Linux), made the expression very long, and on reopening the vector layer properties the dialog stays at an acceptable size. I will post a cast.

---

• resolution was changed from fixed/implemented to
• status_id was changed from Reopened to Feedback

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

I'm at lost here :)

I've made a screencast of how the UI behaves over here, hope that can help.

---

• 7885 was configured as bug.mp4

---

• bug.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Salvatore Larosa (@slarosa)

---

Fixed in changeset "def0a1df91d5390f02dc0fd5f17d3614e396a7a2".

---

• status_id was changed from Feedback to Closed