Processing: Help editor does not save the text

[qgib]

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 11433
Affected QGIS version: 2.8.1
Redmine category:processing/modeller
Assignee: Victor Olaya

---

The user can add alg description etc., but the data are not saved in the model (when it is reopened, the text is not shown)

---

Related issue(s): #19420 (relates), #20321 (duplicates)
Redmine related issue(s): 11087, 12127

---

[qgib]

Author Name: Alexander Bruy (@alexbruy)

---

This caused by recent modeler overhaul

---

• category_id was changed from Processing/GUI to Processing/Modeller
• status_id was changed from Open to Rejected

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

Sorry I miss your point: the data should be saved in the model anyway.

---

• status_id was changed from Rejected to Feedback

[qgib]

Author Name: Alexander Bruy (@alexbruy)

---

There is another ticket about this issue, see #19420.

Anyway, Victor fixed it in master.

---

• resolution was changed from to fixed/implemented
• status_id was changed from Feedback to Closed

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

Still true on 2.8.1

---

• resolution was changed from fixed/implemented to
• status_id was changed from Closed to Reopened

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

• version was changed from 2.4.0 to 2.8.1

[qgib]

Author Name: Arnaud Morvan (@arnaud-morvan)

---

Actually in master help edition dialog work on a copy of the algorithm.
https://github.com/qgis/QGIS/blob/master/python/plugins/processing/modeler/ModelerDialog.py#L224

The help dialog take the (cloned) algorithm as a parameter,
during initialization, it copy algorithm help content into a local variable (but it is reference copy)

it modify the local dictionnary during edition, and the (cloned) algorithm help content in the same time.

on validation
it affect the local dictionnary to the (cloned) algorithm (but it the same reference affectation <=> do nothing)

Note : with the script dialog, after comming back from the help dialog, it get the help content from the help dialog local variable (if help dialog was accepted).

I can propose a simple solution for the model case:
do the same thing that the script dialog

Regards

Arnaud

[qgib]

Author Name: Arnaud Morvan (@arnaud-morvan)

---

I notice that, for the script case, if script help file already exist, help content is written to file on help dialog validation, and written a second time when script is saved.

If script file does not exist, it will be saved only when script file is saved.

For the model case, help content is only write down on model save.

This is not consistent.

I propose to not save script help content in help validation but only in caller acceptation (model or script dialog)
like this it remove some specific code to script and models from the help dialog.

Arnaud

[qgib]

Author Name: Arnaud Morvan (@arnaud-morvan)

---

Pull request proposed: #2058

[qgib]

Author Name: Paolo Cavallini (@pcav)

---

Fixed, merci Arnaud!

---

• status_id was changed from Reopened to Closed
• resolution was changed from to fixed/implemented