Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select by location doesn't work when 'Use selected features only' checkbox is selected but no there is no selection #20904

Closed
qgib opened this issue May 22, 2015 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented May 22, 2015

Author Name: Kilian Steinkohl (Kilian Steinkohl)
Original Redmine Issue: 12808
Affected QGIS version: master
Redmine category:processing/qgis


When using 'Select by location' with 'Use selected features only' checked, the results are not as expected.
When trying to create a new selection based on the intersection of a polygon layer with an existing selection the progress bar starts to move infinitely from one side to the other and the current selection is cleared without creating the expected new selection.

Maybe this is a result of fixing bug report #19241 (8502d11). It seems that the current selection is cleared before the new selection is created. This is obviously contradictory if 'Use selected features only' is checked.

@qgib
Copy link
Contributor Author

qgib commented May 22, 2015

Author Name: Jakob Hvitnov (Jakob Hvitnov)


I am not able to reproduce this on 2.9.0
However the behavior you describe with the progress bar moving from side to side, can be triggered by enabling "use only selected features" while actually not having any selection in the input layer.
It seems the first issue has already been solved on 2.9.0, but it wouuld be a good idea to not have "use only selected features" availiable as an option if features are actually selected.

@qgib
Copy link
Contributor Author

qgib commented May 22, 2015

Author Name: Giovanni Manghi (@gioman)


However the behavior you describe with the progress bar moving from side to side, can be triggered by enabling "use only selected features" while actually not having any selection in the input layer.

exactly, this is the real issue.


  • version was changed from 2.8.2 to master
  • fixed_version_id was configured as Future Release - Lower Priority
  • subject was changed from Select by location doesn't work with 'Use selected features only' checkbox to Select by location doesn't work when 'Use selected features only' checkbox is selected but no there is no selection

@qgib
Copy link
Contributor Author

qgib commented May 22, 2015

Author Name: Kilian Steinkohl (Kilian Steinkohl)


You are correct, the tool is working as intended. My bug report was based on a misconception of the "use only selected features" checkbox. I thought the checkbox applied to the first layer (the layer from which features are selected), so I could narrow down an existing selection. In fact it applies to the second layer (the layer which is checked for intersections with the first one).
As a matter of fact, this is pretty obvious considering the GUI, but as I was expecting a different funcionality, it got me confused.

Concerning the issue with the progress bar, I think there is already a ticket (#15403).

@qgib
Copy link
Contributor Author

qgib commented Jun 1, 2015

Author Name: Saber Razmjooei (@saberraz)


  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


The "ftools" category is being removed from the tracker, changing the category of this ticket to "Processing/QGIS" to not leave the category orphaned.

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
@qgib qgib added this to the Future Release - Lower Priority milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant