Symbol selector dialog: use same terms in the different properties of symbol layer

[qgib]

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 14053

Redmine category:symbology

---

While designing a symbol (marker, line or fill), according to the symbol layer type chosen, in its properties:

• "Rotation" is used in some cases while it's "Angle" in others
• same thing for "Border" vs "Outline"
  It could be nice to use unique terms for all the dialogs

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

Which version does this apply to? Can you give specifics?

---

• status_id was changed from Open to Feedback

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

Hi Nyall,
I'm on 2.12.0 Trusty Tahr but didn't find anything different when (quickly) check these dialogs in master.
In the symbol selector dialog:
For a Marker Symbol: You have "Rotation" when the symbol layer type is Ellipse marker, Font marker while "Angle" is used for SVG Marker and simple marker
For a Fill Symbol : You have "Rotation" when the symbol layer type is Raster Image Fill, SVG Fill while "Angle" is used for Line Pattern Fill, Gradient Fill

Border is afaics consistently used for Fill symbol. So is Outline for Markers. However I wonder if we're not somehow talking about the same thing. Let's take for example the SVG Fill : the border is what is called outline for SVG Marker but it's just same thing.

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

• subject was changed from Symbol selector dialog: use identique terms in the different properties of symbol layer to Symbol selector dialog: use same terms in the different properties of symbol layer

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

So, is this a valid issue? Which terms should be kept:
Rotation vs Angle ?
Border vs Outline ?
According to what's decided, i can propose a PR if no one has time.

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

Propose a fix at #2990

---

• pull_request_patch_supplied was changed from 0 to 1

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

fixed/implemented in 7cb77d8

---

• resolution was changed from to fixed/implemented
• status_id was changed from Feedback to Closed