Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line width size assistant fails to load values when column is name "LENGTH" #22254

Closed
qgib opened this issue Feb 9, 2016 · 11 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers

Comments

@qgib
Copy link
Contributor

qgib commented Feb 9, 2016

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 14258
Affected QGIS version: master
Redmine category:symbology


The assistant fails to load values of a variable (length, real) from a particular layer.
Other variables (integers, strings) are loaded.


@qgib
Copy link
Contributor Author

qgib commented Feb 9, 2016

Author Name: Paolo Cavallini (@pcav)


  • 9557 was configured as strade.zip

@qgib
Copy link
Contributor Author

qgib commented Feb 9, 2016

Author Name: Giovanni Manghi (@gioman)


it works if you use the same datatype but use a different column name... "LENGTH" looks like a reserved word.


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Feb 9, 2016

Author Name: Paolo Cavallini (@pcav)


Good point. However, LENGTH is a valid column name in DBF, and I do not think we should impose additional limitations.

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Giovanni Manghi (@gioman)


Paolo Cavallini wrote:

Good point. However, LENGTH is a valid column name in DBF, and I do not think we should impose additional limitations.

It is a bad practice anyway, I would not be contrary having QGIS not creating columns after any reserved word.


  • os_version was changed from Sid to
  • subject was changed from Line width size assistant fails to load values to Line width size assistant fails to load values when column is name "LENGTH"
  • status_id was changed from Feedback to Open
  • operating_system was changed from Debian to

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Regis Haubourg (@haubourg)


I think it is related to #22253. Can you test adding double quotes on field name "LENGTH" manually the size expression generated?

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Paolo Cavallini (@pcav)


I confirm that with quotes the expression is valid. I cannot check whether variable content is recognized.
I do not agree calling length (or area, etc.) is bad practice: field calc automatically add it.

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Regis Haubourg (@haubourg)


Well, if postgres can be a reference implementation of SQL for us, user fields name is illegal as a SQL keyword when "user" is legal.
Can we just focus on QGIS quoting correctly field names with capitalized , special characters or reserved keywords ?

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Giovanni Manghi (@gioman)


duplicate of #22253


  • status_id was changed from Open to Closed
  • resolution was changed from to duplicate

@qgib
Copy link
Contributor Author

qgib commented Feb 11, 2016

Author Name: Paolo Cavallini (@pcav)


Duplication is possible, but AFAIK not demonstrated. Better leave it open and close it after fix of #22253 and verification.


  • status_id was changed from Closed to Reopened
  • resolution was changed from duplicate to

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0
  • regression was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Mar 7, 2018

Author Name: Paolo Cavallini (@pcav)


Fixed now. Tested in QGIS 3.


  • status_id was changed from Reopened to Closed
  • description was changed from The assistant fails to load values of a variable (length, real) from a particular layer.
    Other variables (integers, strings) are loaded. to The assistant fails to load values of a variable (length, real) from a particular layer.
    Other variables (integers, strings) are loaded.
  • resolution was changed from to fixed/implemented

@qgib qgib closed this as completed Mar 7, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

No branches or pull requests

1 participant