Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "cancel" button for Query Builder get "Sample" Values #22592

Open
qgib opened this issue Apr 7, 2016 · 8 comments
Open

Add a "cancel" button for Query Builder get "Sample" Values #22592

qgib opened this issue Apr 7, 2016 · 8 comments
Labels
Feature Request Vectors Related to general vector layer handling (not specific data formats)

Comments

@qgib
Copy link
Contributor

qgib commented Apr 7, 2016

Author Name: Nikos Tsarmpopoulos (@ntsarb)
Original Redmine Issue: 14627

Redmine category:vectors


Hi,

When hitting the "Sample" button, Query Builder freezes. I presume this is because there's a large database associated with the layer. However, this should not happen. Either the function should quickly return a small resultset, or it should run in a separate thread and the user interface should provide a button to interrupt it and return a small sample.

To reproduce, open a layer with a sufficiently large set, e.g. polygons and data for UK postcodes, open the Query builder and click on "Sample" button.

This has been found on QGIS 2.14.1 64bit, running on Windows 7 Pro 64bit.

@qgib
Copy link
Contributor Author

qgib commented Apr 9, 2016

Author Name: Giovanni Manghi (@gioman)


Please link/attach a dataset that can be used to replicate the issue.


  • category_id was configured as Vectors
  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Apr 28, 2016

Author Name: Saber Razmjooei (@saberraz)


QGIS does some work in the background to generate the sample.

To have it in a separate thread with option to cancel the operation is more of a feature request than a bug.

@qgib
Copy link
Contributor Author

qgib commented May 23, 2016

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from Query Builder (Not Responding) when selecting to get "Sample" Values to Add a "cancel" button for Query Builder get "Sample" Values
  • status_id was changed from Feedback to Open
  • tracker_id was changed from 1 to 2

@qgib
Copy link
Contributor Author

qgib commented Jun 9, 2016

Author Name: Jürgen Fischer (@jef-n)


  • tracker_id was changed from 2 to 1
  • crashes_corrupts_data was changed from 1 to 0

@qgib
Copy link
Contributor Author

qgib commented Jun 9, 2016

Author Name: Jürgen Fischer (@jef-n)


  • tracker_id was changed from 1 to 2

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0

@qgib qgib added Feature Request Vectors Related to general vector layer handling (not specific data formats) labels May 25, 2019
@MrChebur
Copy link
Contributor

MrChebur commented Sep 22, 2020

I would suggest extending the proposed functionality by adding the ability to cancel the execution of any request in the Query Builder. For example, by pressing the Esc key.

@elpaso
Copy link
Contributor

elpaso commented Sep 22, 2020

I agree this would be a nice feature.
We have recently improved this for the new connection API and in DB manager, with #38870 and the upstream OSGeo/gdal#2953 but there is no QGIS data provider API support for that functionality and it's not trivial to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Development

No branches or pull requests

3 participants