Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing plugin intersection module doesn't work properly #22861

Closed
qgib opened this issue May 26, 2016 · 3 comments
Closed

Processing plugin intersection module doesn't work properly #22861

qgib opened this issue May 26, 2016 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented May 26, 2016

Author Name: AZeta Gis (AZeta Gis)
Original Redmine Issue: 14908
Affected QGIS version: 2.14.3
Redmine category:processing/qgis
Assignee: Victor Olaya


The " intersection " module of processing plugin doesn't work properly .
In attached example intersecting the layer "B" with the layer "A" doesn't return any feature while intersecting the layer "A" with the layer "B" is properly returned a feature .
The cause of this bug is the " break " statement at line 106 of the "processing\algs\qgis\Intersection.py" file that prevents the evaluation of the successive intersections . Removing that line the algorithm works correctly.
The implemented algorithm in ftool plugin has a different structure and functioning properly (see lines 961 to 988 in fTools\tools\doGeoprocessing.py ).


@qgib
Copy link
Contributor Author

qgib commented May 26, 2016

Author Name: Alexander Bruy (@alexbruy)


It is not a bug, if intersection result has invalid geometry it skipped.


  • tag was changed from processing, intersection to
  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented May 27, 2016

Author Name: AZeta Gis (AZeta Gis)


Invalid geometry is skipped but the break line interrupts entire cicle and other geometries that overlap first geometry and produce valid intersections don't be evaluated.
In the attached example intersection result changes if input layers are inverted.

@qgib
Copy link
Contributor Author

qgib commented May 27, 2016

Author Name: Victor Olaya (@volaya)


Fixed in changeset "f4ca847660aa066f47af518bcbce00bd52788c9c".


  • status_id was changed from Feedback to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant