-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: QGIS crashes when closing docked attribute table #22862
Comments
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Note: you might have to open and close the attribute table panel twice to trigger the crash. On my machine, it crashes either on first or second closure. |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) -If I disable TimeManager, crash is gone; closing.-
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I was wrong, the crasher is still occuring even when timemanager (and other plugins) are disabled. Nathan can reproduce the crasher.
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I've installed Qt's debug package, here's a more complete gdb output of the crasher:
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) Still crashing; updated gdb trace:
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
|
Author Name: Even Rouault (@rouault) I've investigated this and identified more precisely the cause of the crash. The Valgrind log shows it is a double free issue :
Digging more, I've identified that the following code in QgsAttributeTableView::setModel() is the cause :
If the widget is not created, or updateActionImage() not called, then there's no crash. Alternatively, if you keep that code but change QgsAttributeTableView::createActionWidget() so that the toolButton = new QToolButton( this ) and container = new QWidget( this ) use nullptr instead of this as a parent, there's no crash (but the painting of the icon is corrupted). So there's an ownership issue with the backing store of this widget... |
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV) I noticed a larger OGR dataset will do a better job at replicating the crash quicker (i.e., you won't need to open -> close -> open -> close -> etc. for long). See attached video.
|
Author Name: Anónimo (Anónimo) Fixed in changeset "a05b2ad9a1ace292e77dbe8541240c0c8bc2a096".
|
Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 14909
Affected QGIS version: master
Redmine category:attribute_table
Assignee: Nathan Woodrow
Steps to reproduce:
The gdb's where output:
Related issue(s): #22965 (duplicates)
Redmine related issue(s): 15018
The text was updated successfully, but these errors were encountered: