WMS Legend Image is flawed: WMS getLegendGraphic url's get double names/keys

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)
Original Redmine Issue: 15055
Affected QGIS version: master
Redmine category:unknown

---

IF a WMS service provides GetLegendGraphic url's in it's capabilities, QGIS tries to retrieve the legendimage and shows it in the layermanager.

Some services provide full url's, others only parts, that is why in current implementation there is a check IF certain query-names are available in the url-query and else are added:
https://github.com/qgis/QGIS/blob/master/src/providers/wms/qgswmsprovider.cpp#L2993

BUT certain services provide the url in lowercase key/value pairs, resulting in double key/value pairs in the url, resulting in error messages instead of images.

To test: add a layer from this service:
http://geoservices.knmi.nl/cgi-bin/RADNL_OPER_R___25PCPRR_L3.cgi?

I have already created a patch for it, and will do a pull request

---

• legendflawed.png (Richard Duivenvoorde)

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

FYI without patch this is te resulting getLegendGraphic url:

http://geoservices.knmi.nl/cgi-bin/RADNL_OPER_R___25PCPRR_L3.cgi?SERVICE=WMS&&version=1.1.1&service=WMS&request=GetLegendGraphic&layer=RADNL_OPER_R___25PCPRR_L3_KNMI&format=image/png&STYLE=default&&VERSION=1.3.0&SLD_VERSION=1.1.0&REQUEST=GetLegendGraphic&FORMAT=image/png&LAYER=RADNL_OPER_R___25PCPRR_L3_KNMI

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

• 10031 was configured as legendflawed.png

---

• legendflawed.png (Richard Duivenvoorde) - Legend Flawed message in layermanager

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

Fixed in changeset "543d5211332a885960a19b4a7ca7ff3296838a27".

---

• status_id was changed from Open to Closed

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

• category_id was configured as Unknown