Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fields: an expression is always required (otherwise python error is thrown) #23563

Closed
qgib opened this issue Sep 29, 2016 · 5 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Sep 29, 2016

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 15640
Affected QGIS version: 3.0.0
Redmine category:processing/core


When creating a new field through Processing > Refactor fields, an expression seems always required. I do not think this should be necessary, because users sometimes want just to add a new empty column to be filled afterwards.

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0
  • regression was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2018

Author Name: Paolo Cavallini (@pcav)


Adding a string whatsoever is a workaround, but I still think the alg should accept an empty expression instead of throwing:

Traceback (most recent call last): File "/usr/local/src/qgis/QGIS/build_qgis3/output/python/plugins/processing/algs/qgis/FieldsMapper.py", line 144, in prepareAlgorithm expression.parserErrorString())) _core.QgsProcessingException: Parser error in expression "": syntax error, unexpected $end


  • assigned_to_id removed Victor Olaya
  • version was changed from 2.16.3 to 3.0.0

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2018

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from Refactor fields: an expression is always required to Refactor fields: an expression is always required (otherwise python error is thrown)
  • category_id was changed from Processing/GUI to Processing/Core

@qgib
Copy link
Contributor Author

qgib commented Feb 25, 2018

Author Name: Nyall Dawson (@nyalldawson)


Applied in changeset cc10bbd.


  • status_id was changed from Open to Closed
  • done_ratio was changed from 0 to 100

@qgib qgib closed this as completed Feb 25, 2018
@qgib
Copy link
Contributor Author

qgib commented Feb 27, 2018

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant