Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleparts to multi-part polygon algorithm uses NULL values also #23742

Closed
qgib opened this issue Nov 7, 2016 · 5 comments
Closed

Singleparts to multi-part polygon algorithm uses NULL values also #23742

qgib opened this issue Nov 7, 2016 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Nov 7, 2016

Author Name: Sharachchandra Lele (Sharachchandra Lele)
Original Redmine Issue: 15822
Affected QGIS version: 2.14.2
Redmine category:processing/qgis


I have a polygon shapefile with an attribute villageID, in which some polygons have the same attribute value and so they should together form a single multi-part polygon. Some other polygons have NULL in this villageID field. When I run the tool Vector>Geometry Tools>Singleparts to Multipart (from the menu or from Procsesing Toolbox, and whether I use the GDAL version or the QGIS geoalgorithm version), the resulting shapefile does merge the repeated villageIDs into multi-part polygons. But it ALSO merges ALL the polygons that had this field = NULL into a SINGLE multi-part polygon. In effect, it is treating all NULL values as equal, when in fact it should treat NULL as 'not known' and ignore those polygons. If I run a 'find duplicates' query in MS-ACCESS on the attribute table dbf, the query ignores those rows where villageID=NULL, which IMHO is the correct method.

@qgib
Copy link
Contributor Author

qgib commented Apr 27, 2017

Author Name: Alexander Bruy (@alexbruy)


  • category_id was configured as Processing/QGIS

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Alexander Bruy (@alexbruy)


Fixed in a944f7c


  • status_id was changed from Open to Closed
  • resolution was changed from to fixed/implemented

@qgib
Copy link
Contributor Author

qgib commented May 1, 2017

Author Name: Jürgen Fischer (@jef-n)


  • status_id was changed from Closed to Reopened
  • regression was configured as 0
  • resolution was changed from fixed/implemented to
  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented May 16, 2017

Author Name: Alexander Bruy (@alexbruy)


Applied in changeset e4d745f.


  • status_id was changed from Reopened to Closed
  • done_ratio was changed from 0 to 100

@qgib qgib closed this as completed May 16, 2017
@qgib
Copy link
Contributor Author

qgib commented May 16, 2017

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant