Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concave hull not working in Processing (QGIS3) #23901

Closed
qgib opened this issue Dec 15, 2016 · 10 comments
Closed

Concave hull not working in Processing (QGIS3) #23901

qgib opened this issue Dec 15, 2016 · 10 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Dec 15, 2016

Author Name: matteo ghetta (@ghtmtt)
Original Redmine Issue: 15985
Affected QGIS version: master
Redmine category:processing/qgis
Assignee: Nyall Dawson


Concave hull algorithm always throws an error. In QGIS 2.18 it works fine (tested with point data within the processing test framework)

2016-12-15T10:47:55 2 Uncaught error while executing algorithm
Traceback (most recent call last):
File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/core/GeoAlgorithm.py", line 213, in execute
self.processAlgorithm(progress)
File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/qgis/ConcaveHull.py", line 76, in processAlgorithm
features = delaunay_layer.getFeatures()
AttributeError: 'NoneType' object has no attribute 'getFeatures'

@qgib
Copy link
Contributor Author

qgib commented Jan 4, 2017

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to Severe/Regression

@qgib
Copy link
Contributor Author

qgib commented Feb 7, 2017

Author Name: Alexander Bruy (@alexbruy)


This happens because now temporary layers are memory layers and Processing fails to locate algorithm result

@qgib
Copy link
Contributor Author

qgib commented Feb 14, 2017

Author Name: matteo ghetta (@ghtmtt)


Ok, any chance or way to fix this? Can I help making other tests?

Thanks again!

@qgib
Copy link
Contributor Author

qgib commented Apr 28, 2017

Author Name: Arnaud Morvan (@arnaud-morvan)


For now, with Nyall work on porting processing to c++.
The @processing.run@ method create a @QgsProcessingContext@ (in @Processing.runAlgorithm@) and the ouput, some memory layer is placed in @context.temporaryStore@.
But it is not possible to pass the parent (caller) algorithm context to @processing.run@ so it is not possible to get back the layer object.

I see the possibility to add a context parameter to processing.run, like is done with feedback.

@qgib
Copy link
Contributor Author

qgib commented Apr 29, 2017

Author Name: Arnaud Morvan (@arnaud-morvan)


Here is a pull request that highlight the situation : #4439
It fix the error, but Nyall may have other plans.

@qgib
Copy link
Contributor Author

qgib commented Apr 29, 2017

Author Name: Arnaud Morvan (@arnaud-morvan)


  • assigned_to_id was changed from Victor Olaya to Nyall Dawson

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • regression was configured as 1

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Severe/Regression to High

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented May 2, 2017

Author Name: Arnaud Morvan (@arnaud-morvan)


Applied in changeset e232a08.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed May 2, 2017
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore labels May 25, 2019
@qgib qgib added this to the Version 3.0 milestone May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant