Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing: GRASS commands not escaped correctly #24016

Closed
qgib opened this issue Jan 23, 2017 · 6 comments
Closed

Processing: GRASS commands not escaped correctly #24016

qgib opened this issue Jan 23, 2017 · 6 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS High Priority
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Jan 23, 2017

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 16104
Affected QGIS version: 2.18.2
Redmine category:processing/grass
Assignee: Victor Olaya


A simple GRASS command, e.g.

processing.runalg("grass7:v.clean","/home/paolo/Aree_Elementari.shp",2,0.1,"955403.9934,1054537.9351,4596890.3389,4678902.6515",-1,0.0001,None,None)

results in:

v.in.ogr min_area=0.0001 snap=-1 input="/home/paolo/" layer=Aree Elementari output=tmp14851690580813 --overwrite -o

instead of:

v.in.ogr min_area=0.0001 snap=-1 input="/home/paolo/" layer="Aree Elementari" output=tmp14851690580813 --overwrite -o

(the space in filename is not escaped) and as a consequence the command fails with:

ERROR: Sorry is not a valid option

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: Giovanni Manghi (@gioman)


If is regression is a severe, not high issue.

Anyway I cannot replicate (2.18.3, grass72), so please add

  1. sample data
  2. exact steps on how replicate

  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: Victor Olaya (@volaya)


Giovanni, i guess it will happen when you use any layer with blank spaces in its name as input

Should be easy to fix, i will work on it

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: Giovanni Manghi (@gioman)


Victor Olaya wrote:

Giovanni, i guess it will happen when you use any layer with blank spaces in its name as input

Should be easy to fix, i will work on it

Hi Victor,
yes it seems to happen when input layer name has spaces. But the above example does not have spaces in the input file name

processing.runalg("grass7:v.clean","/home/paolo/Aree_Elementari.shp",2,0.1,"955403.9934,1054537.9351,4596890.3389,4678902.6515",-1,0.0001,None,None)

and in another test using an input with underscores this are not replaced by spaces (as the above example would suggest).

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: luca barbadoro (luca barbadoro)


  • fixed_version_id was configured as Version 2.14

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: Paolo Cavallini (@pcav)


I believe Victor has already fixed this.

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2017

Author Name: Giovanni Manghi (@gioman)


https://github.com/qgis/QGIS/pull/4046/files#diff-0


  • resolution was changed from to fixed/implemented
  • status_id was changed from Feedback to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority GRASS labels May 25, 2019
@qgib qgib added this to the Version 2.14 milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS High Priority
Projects
None yet
Development

No branches or pull requests

1 participant