Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: (much) slower rendering (and attribute table opening) time compared to 2.18.4 #24149

Closed
qgib opened this issue Feb 27, 2017 · 20 comments
Closed
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Map and Legend Related to map or legend rendering Regression Something which used to work, but doesn't anymore
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Feb 27, 2017

Author Name: Giovanni Manghi (@gioman)
Original Redmine Issue: 16239
Affected QGIS version: master
Redmine category:map_canvas


On the same machine, with the same settings, the rendering time of QGIS master seems much slower if compared to (for example) 2.18.4

For a 160k polygon features shapefile (which I can provide privately to a dev if necessary) the time to render the layer on master is around 30 seconds, while is around 7/8 on 2.18.4

For what is worth also the time to open the attribute table for the same vector is much slower on master, around 15 seconds compared to around 5.


Related issue(s): #23674 (relates), #24414 (relates), #24479 (relates)
Redmine related issue(s): 15752, 16508, 16577


@qgib
Copy link
Contributor Author

qgib commented Feb 27, 2017

Author Name: Nyall Dawson (@nyalldawson)


Can you shoot me a link to the data/project? Nyall.dawson@gmail.com

@qgib
Copy link
Contributor Author

qgib commented Feb 27, 2017

Author Name: Giovanni Manghi (@gioman)


Nyall Dawson wrote:

Can you shoot me a link to the data/project? Nyall.dawson@gmail.com

sent using DropBox. Cheers!

@qgib
Copy link
Contributor Author

qgib commented Mar 3, 2017

Author Name: Giovanni Manghi (@gioman)


see also #23674

@qgib
Copy link
Contributor Author

qgib commented Apr 1, 2017

Author Name: Nyall Dawson (@nyalldawson)


Giovanni,

Are both builds you are using for comparison debug builds? Or are you comparing a release build vs debug build?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Apr 3, 2017

Author Name: Giovanni Manghi (@gioman)


Nyall Dawson wrote:

Giovanni,

Are both builds you are using for comparison debug builds? Or are you comparing a release build vs debug build?

I used qgis-master from osgeo4w and 2.14/2.18 from the very same osgeo4w install within the same machine.


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Apr 4, 2017

Author Name: Andre Jesus (Andre Jesus)


I guess the issue in #23674 can be merged into this one, as the render time is rising in all data sources.

Using Windows 10 64 Bits, OSGeo4W installer 64 Bits:

3x avg render time, +MSSQL+
2.14.13
3100 ms
2.99.0
8800 ms +64.7%

3x avg render time, +Postgres+
2.14.13
1300 ms
2.99.0
3600 ms +63.8%

Project info:
image

As said in #23674, if we compare It to 2.8.9 version the time difference is absurd

@qgib
Copy link
Contributor Author

qgib commented Apr 4, 2017

Author Name: Jürgen Fischer (@jef-n)


Are you comparing builds writing debugging output (qgis-ltr-dev/qgis-rel-dev/qgis-dev; see corresponding note in the about box) and builds not writing debugging output (qgis/qgis-ltr)? Writing debugging output has a performance impact.

@qgib
Copy link
Contributor Author

qgib commented Apr 4, 2017

Author Name: Andre Jesus (Andre Jesus)


Jürgen Fischer wrote:

Are you comparing builds writing debugging output (qgis-ltr-dev/qgis-rel-dev/qgis-dev; see corresponding note in the about box) and builds not writing debugging output (qgis/qgis-ltr)? Writing debugging output has a performance impact.

Yes, I was: qgis-ltr (2.14.13) vs qgis-dev (2.99.0). And you are right, the render time using qgis-ltr-dev is bigger:

2.14.13-2 (qgis-ltr-dev)
+MSSQL+: 5100 ms
+Postgres+: 3000 ms

But again, please check #23674.
Every version since 2.10.x has constantly rising the render time by a high percentage.

@qgib
Copy link
Contributor Author

qgib commented Apr 12, 2017

Author Name: Nyall Dawson (@nyalldawson)


I believe this report can be closed - it seems the issue was stemming from comparing the debug vs release builds.

#23674 describes a regression in the speed of the mssql provider. I think this is a separate issue which should be left open.


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Apr 13, 2017

Author Name: Giovanni Manghi (@gioman)


Nyall Dawson wrote:

I believe this report can be closed - it seems the issue was stemming from comparing the debug vs release builds.

#23674 describes a regression in the speed of the mssql provider. I think this is a separate issue which should be left open.

before closing I can compile master with no debug output and try again. Thanks.

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • regression was configured as 1

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Severe/Regression to High

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented May 1, 2017

Author Name: Alexander Bruy (@alexbruy)


Probably related to #23674


  • description was changed from On the same machine, with the same settings, the rendering time of QGIS master seems much slower if compared to (for example) 2.18.4

For a 160k polygon features shapefile (which I can provide privately to a dev if necessary) the time to render the layer on master is around 30 seconds, while is around 7/8 on 2.18.4

For what is worth also the time to open the attribute table for the same vector is much slower on master, around 15 seconds compared to around 5. to On the same machine, with the same settings, the rendering time of QGIS master seems much slower if compared to (for example) 2.18.4

For a 160k polygon features shapefile (which I can provide privately to a dev if necessary) the time to render the layer on master is around 30 seconds, while is around 7/8 on 2.18.4

For what is worth also the time to open the attribute table for the same vector is much slower on master, around 15 seconds compared to around 5.

@qgib
Copy link
Contributor Author

qgib commented May 18, 2017

Author Name: Giovanni Manghi (@gioman)


Nyall Dawson wrote:

I believe this report can be closed - it seems the issue was stemming from comparing the debug vs release builds.

#23674 describes a regression in the speed of the mssql provider. I think this is a separate issue which should be left open.

see #24479 (datasouces shapefiles)

@qgib
Copy link
Contributor Author

qgib commented May 19, 2017

Author Name: Jürgen Fischer (@jef-n)


@qgib
Copy link
Contributor Author

qgib commented May 19, 2017

Author Name: Jürgen Fischer (@jef-n)


@qgib
Copy link
Contributor Author

qgib commented May 20, 2017

Author Name: Giovanni Manghi (@gioman)


Nyall Dawson wrote:

I believe this report can be closed - it seems the issue was stemming from comparing the debug vs release builds.

#23674 describes a regression in the speed of the mssql provider. I think this is a separate issue which should be left open.

Hi Nyall,

I think that this new (among the many others) report speaks volumes:

https://lists.osgeo.org/pipermail/qgis-psc/2017-May/005258.html


  • version was changed from master to 2.18.7
  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Jul 25, 2017

Author Name: Giovanni Manghi (@gioman)


  • version was changed from 2.18.7 to master

@qgib
Copy link
Contributor Author

qgib commented Jun 16, 2018

Author Name: Nyall Dawson (@nyalldawson)


Applied in changeset ce74d57.


  • status_id was changed from Open to Closed
  • done_ratio was changed from 0 to 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Map and Legend Related to map or legend rendering Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant