DB Manager: previewing layers in Virtual layers section remove them from the Layers panel

[qgib]

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 16476
Affected QGIS version: master
Redmine category:db_manager

---

Open a project
Launch DB Manager, expand the Virtual layers section, then QGIs layers and select a layer
Click the Preview tab
Select another layer
The layer you selected first has been removed from the Layers panel, hence from the project (GUI, at least)

Happens also in master
Set the report as high because this can easily corrupt the project if you don't notice the removal (and anyway, if you notice it, you'll need to close and not save the project to avoid it being corrupted)

---

Related issue(s): #24440 (duplicates)
Redmine related issue(s): 16534

---

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

• subject was changed from DB Manager: previewing layers remove them from the Layers panel to DB Manager: previewing layers in Virtual layers section remove them from the Layers panel

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• regression was configured as 0
• easy_fix was configured as 0

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• description was changed from Open a project
  Launch DB Manager, expand the Virtual layers section, then QGIs layers and select a layer
  Click the Preview tab
  Select another layer
  The layer you selected first has been removed from the Layers panel, hence from the project (GUI, at least)

Happens also in master
Set the report as high because this can easily corrupt the project if you don't notice the removal (and anyway, if you notice it, you'll need to close and not save the project to avoid it being corrupted) to Open a project
Launch DB Manager, expand the Virtual layers section, then QGIs layers and select a layer
Click the Preview tab
Select another layer
The layer you selected first has been removed from the Layers panel, hence from the project (GUI, at least)

Happens also in master
Set the report as high because this can easily corrupt the project if you don't notice the removal (and anyway, if you notice it, you'll need to close and not save the project to avoid it being corrupted)

• crashes_corrupts_data was changed from 0 to 1

[qgib]

Author Name: Luigi Pirelli (@luipir)

---

the problem is a logic problem... the db_manager base class layer_preview remove from registry any previously added layer (currentLayer) with it's id, with assumption that it's id is a temporary layer because has been added for the preview.

virtual layer qgis layer is populated of all registry layers => also that are in the layer list, when you click on that it become current layer => it is removed when switching to another layer in db_manager

looking for a simple solution for that

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

see also #24440

[qgib]

Author Name: Luigi Pirelli (@luipir)

---

fixed for 2.18 #4534 waiting for review and merge, expecially review by Hugo Mercier.
fix for 3.0 will be delayed because actually in this version db_manager raise much more exception than the 2.18 or 2.14 one => I'll try to work in a general PR fixup most common one.

---

• pull_request_patch_supplied was changed from 0 to 1

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

• duplicated was configured as DB manager virtual layers: wrong list, layers removed from project #24440

[qgib]

Author Name: Salvatore Larosa (@slarosa)

---

Applied in changeset dae921c.

---

• status_id was changed from Open to Closed

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

Looks like the fix for QGIS 3 never landed

---

• status_id was changed from Closed to Reopened
• version was changed from 2.18.7 to master

[qgib]

Author Name: Salvatore Larosa (@slarosa)

---

Applied in changeset 68b7bf6.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Reopened to Closed

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• resolution was changed from to fixed/implemented