Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If multi threaded rendering is enabled adding a WCS Layer makes multiple GetCoverage calls #24722

Closed
qgib opened this issue Jul 10, 2017 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers

Comments

@qgib
Copy link
Contributor

qgib commented Jul 10, 2017

Author Name: William Valencia (William Valencia)
Original Redmine Issue: 16823
Affected QGIS version: 2.18.9
Redmine category:web_services_clients/wcs


I have a WCS Server and I use QGIS to add a WCS Layer from my WCS server. I noticed there is 1 GetCapabilities call, 1 DescribeCoverage call, and 4 GetCoverage calls that QGIS requests from my server for adding a single layer. This seems excessive. Shouldn't there be only 1 GetCoverage call?

This is running 2.18.9 QGIS on OSX.

QGIS version
2.18.9
QGIS code branch
Release 2.18
Compiled against Qt
4.8.6
Running against Qt
4.8.6
Compiled against GDAL/OGR
2.1.3
Running against GDAL/OGR
2.1.2
Compiled against GEOS
3.6.1-CAPI-1.10.1
Running against GEOS
3.5.1-CAPI-1.9.1 r4246
PostgreSQL Client Version
9.3.4
SpatiaLite Version
4.3.0a
QWT Version
6.1.3
PROJ.4 Version
492

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: William Valencia (William Valencia)


I noticed something weird with QGIS. So when making an "Add WCS Layer" request with QGIS, I noticed that (After initial GetCapabilities and DescribeCoverage), multiple redundant calls to my WCS Server are made. The actual "Add" Button makes 12 calls to EGI. It calls 1 GetCapabilities, 1 DescribeCoverage, 4 GetCoverage and then repeats the last 6 calls for a total of 12 calls. I am unsure why QGIS makes 4 GetCoverage calls in the first place, then it repeats the last 6 calls.

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: Giovanni Manghi (@gioman)


Would you mind asking in the developers mailing list of this is expected or not? thanks.


  • priority_id was changed from High to Normal
  • category_id was changed from Actions to Web Services clients/WCS
  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jul 19, 2017

Author Name: William Valencia (William Valencia)


I asked the developers mailing list and included their response below. Looks like the extra 6 repeated calls are definitely a bug with multi threaded rendering. The multiple (4) GetCoverage calls may or may not be needed any more as well.

Hi William

On Wed, Jul 12, 2017 at 8:29 AM, William Valencia
william.m.valencia@nasa.gov wrote:

I noticed something weird with QGIS. So when making an "Add WCS Layer"
request with QGIS, I noticed that (After initial GetCapabilities and
DescribeCoverage), multiple redundant calls to my WCS Server are made. The
actual "Add" Button makes 12 calls to my WCS Server. It calls 1
GetCapabilities, 1 DescribeCoverage, 4 GetCoverage and then repeats the last
6 calls for a total of 12 calls. I am unsure why QGIS makes 4 GetCoverage
calls in the first place, let alone the repeated last 6 calls for the total
of 12 calls. Anyone know why QGIS is doing this?

I am not the author of the WCS provider, but I have some leads... the
extra GetCoverage calls are used for detection of some server
behaviors, from the code comments it looks like at some point there
were incompatibilities among WCS server implementations that lead to
addition of these checks to work around the incompatibilities. Not
sure if these checks are still necessary with the current versions of
map servers.

For the repeated calls, this a side-effect of introduction of
multi-threaded rendering since QGIS 2.4. WCS provider get cloned for
use in worker thread, but the cloning is sub-optimal - it does not
pass the downloaded capabilities, so cloned provider has to fetch that
again. It should not be hard to fix (I have fixed that for WMS in the
initial work, but WCS provider had low priority at the time).

Regards
Martin

@qgib
Copy link
Contributor Author

qgib commented Sep 25, 2017

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from Adding a WCS Layer makes multiple (4) GetCoverage calls. to If multi threaded rendering is enabled adding a WCS Layer makes multiple GetCoverage calls
  • status_id was changed from Feedback to Open
  • operating_system was changed from MacOS Sierra 10.12.5 to

@qgib
Copy link
Contributor Author

qgib commented Mar 9, 2019

Author Name: Giovanni Manghi (@gioman)


End of life notice: QGIS 2.18 LTR

Source:
http://blog.qgis.org/2019/03/09/end-of-life-notice-qgis-2-18-ltr/

QGIS 3.4 has recently become our new Long Term Release (LTR) version. This is a major step in our history – a long term release version based on the massive updates, library upgrades and improvements that we carried out in the course of the 2.x to 3x upgrade cycle.

We strongly encourage all users who are currently using QGIS 2.18 LTR as their preferred QGIS release to migrate to QGIS 3.4. This new LTR version will receive regular bugfixes for at least one year. It also includes hundreds of new functions, usability improvements, bugfixes, and other goodies. See the relevant changelogs for a good sampling of all the new features that have gone into version 3.4

Most plugins have been either migrated or incorporated into the core QGIS code base.

We strongly discourage the continued use of QGIS 2.18 LTR as it is now officially unsupported, which means we’ll not provide any bug fix releases for it.

You should also note that we intend to close all bug tickets referring to the now obsolete LTR version. Original reporters will receive a notification of the ticket closure and are encouraged to check whether the issue persists in the new LTR, in which case they should reopen the ticket.

If you would like to better understand the QGIS release roadmap, check out our roadmap page! It outlines the schedule for upcoming releases and will help you plan your deployment of QGIS into an operational environment.

The development of QGIS 3.4 LTR has been made possible by the work of hundreds of volunteers, by the investments of companies, professionals, and administrations, and by continuous donations and financial support from many of you. We sincerely thank you all and encourage you to collaborate and support the project even more, for the long term improvement and sustainability of the QGIS project.


  • resolution was changed from to end of life
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Mar 9, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Development

No branches or pull requests

1 participant